Subject: Re: [HACKERS] Userset logging
From: Simon Riggs <simon@2ndquadrant.com>
To: List pgsql-patches <pgsql-patches@postgresql.org>
In-Reply-To: <1215443593.4051.601.camel@ebony.site>
References: <1215443593.4051.601.camel@ebony.site>
Content-Type: multipart/mixed; boundary="=-/lDk4JAZiBWJYz8rcHyp"
Date: Tue, 08 Jul 2008 08:36:21 +0100
Message-Id: <1215502581.4051.674.camel@ebony.site>
Mime-Version: 1.0


--=-/lDk4JAZiBWJYz8rcHyp
Content-Type: text/plain
Content-Transfer-Encoding: 7bit


On Mon, 2008-07-07 at 16:13 +0100, Simon Riggs wrote:
> I notice log_temp_files is a PGC_USERSET parameter, which is out of step
> with our current thinking on who is allowed to initiate logging.
> 
> Is there a rationale for this? Or should we set this to PGC_SUSET like
> all the other logging functions?

Patch enclosed.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

--=-/lDk4JAZiBWJYz8rcHyp
Content-Disposition: attachment; filename=log_temp_files_suset.v1.patch
Content-Type: text/x-patch; name=log_temp_files_suset.v1.patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: src/backend/utils/misc/guc.c
===================================================================
RCS file: /home/sriggs/pg/REPOSITORY/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.461
diff -c -r1.461 guc.c
*** src/backend/utils/misc/guc.c	1 Jul 2008 21:07:33 -0000	1.461
--- src/backend/utils/misc/guc.c	8 Jul 2008 06:03:18 -0000
***************
*** 1861,1867 ****
  	},
  
  	{
! 		{"log_temp_files", PGC_USERSET, LOGGING_WHAT,
  			gettext_noop("Log the use of temporary files larger than this number of kilobytes."),
  			gettext_noop("Zero logs all files. The default is -1 (turning this feature off)."),
  			GUC_UNIT_KB
--- 1861,1867 ----
  	},
  
  	{
! 		{"log_temp_files", PGC_SUSET, LOGGING_WHAT,
  			gettext_noop("Log the use of temporary files larger than this number of kilobytes."),
  			gettext_noop("Zero logs all files. The default is -1 (turning this feature off)."),
  			GUC_UNIT_KB

--=-/lDk4JAZiBWJYz8rcHyp--