Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 9C9036502C0 for ; Wed, 16 Jul 2008 13:55:57 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 31672-02-3 for ; Wed, 16 Jul 2008 13:55:46 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mk-outboundfilter-3.mail.uk.tiscali.com (mk-outboundfilter-3.mail.uk.tiscali.com [212.74.114.23]) by postgresql.org (Postfix) with ESMTP id 019DE650307 for ; Wed, 16 Jul 2008 13:49:45 -0300 (ADT) X-Trace: 146051675/mk-outboundfilter-1.mail.uk.tiscali.com/F2S/$F2S-NILDRAM-ACCEPTED/f2s-temporary-group/85.211.229.155 X-SBRS: None X-RemoteIP: 85.211.229.155 X-IP-MAIL-FROM: simon@2ndquadrant.com X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtoAAOTCfUhV0+Wb/2dsb2JhbAAIsRU X-IronPort-AV: E=Sophos;i="4.30,374,1212361200"; d="scan'208";a="146051675" X-IP-Direction: IN Received: from 85-211-229-155.dyn.gotadsl.co.uk (HELO [192.168.0.3]) ([85.211.229.155]) by smtp.f2s.tiscali.co.uk with ESMTP; 16 Jul 2008 17:49:43 +0100 Subject: Is autovacuum doing a wraparound-avoiding VACUUM? From: Simon Riggs To: List pgsql-patches Content-Type: multipart/mixed; boundary="=-UXQtIRgEF4H/3cT+Hh8g" Date: Wed, 16 Jul 2008 17:55:39 +0100 Message-Id: <1216227339.19656.364.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.034 tagged_above=0 required=5 tests=AWL=0.034 X-Spam-Level: X-Archive-Number: 200807/169 X-Sequence-Number: 6863 --=-UXQtIRgEF4H/3cT+Hh8g Content-Type: text/plain Content-Transfer-Encoding: 7bit Is autovacuum doing a wraparound-avoiding VACUUM? Currently, no easy way to tell. Patch to change message of autovac in pg_stat_activity when we are performing an anti-wraparound VACUUM. We will then be able to explain why an autovacuum process doesn't get cancelled, like we might otherwise hope it would be. That way we can tell difference between hung and just important. Perhaps message should say "non-automatically cancelled VACUUM ", but that sounded more obscure than the phrase I selected. Discuss... -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support --=-UXQtIRgEF4H/3cT+Hh8g Content-Disposition: attachment; filename=wraparound_msg.v1.patch Content-Type: text/x-patch; name=wraparound_msg.v1.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: src/backend/postmaster/autovacuum.c =================================================================== RCS file: /home/sriggs/pg/REPOSITORY/pgsql/src/backend/postmaster/autovacuum.c,v retrieving revision 1.80 diff -c -r1.80 autovacuum.c *** src/backend/postmaster/autovacuum.c 1 Jul 2008 02:09:34 -0000 1.80 --- src/backend/postmaster/autovacuum.c 16 Jul 2008 16:23:36 -0000 *************** *** 290,296 **** static PgStat_StatTabEntry *get_pgstat_tabentry_relid(Oid relid, bool isshared, PgStat_StatDBEntry *shared, PgStat_StatDBEntry *dbentry); ! static void autovac_report_activity(VacuumStmt *vacstmt, Oid relid); static void avl_sighup_handler(SIGNAL_ARGS); static void avl_sigusr1_handler(SIGNAL_ARGS); static void avl_sigterm_handler(SIGNAL_ARGS); --- 290,296 ---- static PgStat_StatTabEntry *get_pgstat_tabentry_relid(Oid relid, bool isshared, PgStat_StatDBEntry *shared, PgStat_StatDBEntry *dbentry); ! static void autovac_report_activity(VacuumStmt *vacstmt, Oid relid, bool for_wraparound); static void avl_sighup_handler(SIGNAL_ARGS); static void avl_sigusr1_handler(SIGNAL_ARGS); static void avl_sigterm_handler(SIGNAL_ARGS); *************** *** 2626,2632 **** vacstmt.va_cols = NIL; /* Let pgstat know what we're doing */ ! autovac_report_activity(&vacstmt, relid); vacuum(&vacstmt, relid, bstrategy, for_wraparound, true); } --- 2626,2632 ---- vacstmt.va_cols = NIL; /* Let pgstat know what we're doing */ ! autovac_report_activity(&vacstmt, relid, for_wraparound); vacuum(&vacstmt, relid, bstrategy, for_wraparound, true); } *************** *** 2643,2649 **** * bother to report "" or some such. */ static void ! autovac_report_activity(VacuumStmt *vacstmt, Oid relid) { char *relname = get_rel_name(relid); char *nspname = get_namespace_name(get_rel_namespace(relid)); --- 2643,2649 ---- * bother to report "" or some such. */ static void ! autovac_report_activity(VacuumStmt *vacstmt, Oid relid, bool for_wraparound) { char *relname = get_rel_name(relid); char *nspname = get_namespace_name(get_rel_namespace(relid)); *************** *** 2652,2658 **** char activity[MAX_AUTOVAC_ACTIV_LEN]; /* Report the command and possible options */ ! if (vacstmt->vacuum) snprintf(activity, MAX_AUTOVAC_ACTIV_LEN, "autovacuum: VACUUM%s", vacstmt->analyze ? " ANALYZE" : ""); --- 2652,2661 ---- char activity[MAX_AUTOVAC_ACTIV_LEN]; /* Report the command and possible options */ ! if (for_wraparound) ! snprintf(activity, MAX_AUTOVAC_ACTIV_LEN, ! "autovacuum: VACUUM to avoid wraparound of "); ! else if (vacstmt->vacuum) snprintf(activity, MAX_AUTOVAC_ACTIV_LEN, "autovacuum: VACUUM%s", vacstmt->analyze ? " ANALYZE" : ""); --=-UXQtIRgEF4H/3cT+Hh8g--