Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 7E3A56501F6 for ; Mon, 21 Jul 2008 03:16:19 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 94638-01-3 for ; Mon, 21 Jul 2008 03:16:13 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mk-outboundfilter-4.mail.uk.tiscali.com (mk-outboundfilter-4.mail.uk.tiscali.com [212.74.114.32]) by postgresql.org (Postfix) with ESMTP id 04B8B65020A for ; Mon, 21 Jul 2008 03:05:19 -0300 (ADT) X-Trace: 113682066/mk-outboundfilter-2.mail.uk.tiscali.com/F2S/$F2S-NILDRAM-ACCEPTED/f2s-temporary-group/85.211.229.155 X-SBRS: None X-RemoteIP: 85.211.229.155 X-IP-MAIL-FROM: simon@2ndquadrant.com X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah8BAHTDg0hV0+Wb/2dsb2JhbAAIrQE X-IronPort-AV: E=Sophos;i="4.31,221,1215385200"; d="scan'208";a="113682066" X-IP-Direction: IN Received: from 85-211-229-155.dyn.gotadsl.co.uk (HELO [192.168.0.3]) ([85.211.229.155]) by smtp.f2s.tiscali.co.uk with ESMTP; 21 Jul 2008 07:05:12 +0100 Subject: Re: pg_dump additional options for performance From: Simon Riggs To: Stephen Frost Cc: pgsql-patches@postgresql.org In-Reply-To: <20080721011829.GC18846@tamriel.snowman.net> References: <20080720030749.GA18846@tamriel.snowman.net> <1216529229.19656.835.camel@ebony.2ndQuadrant> <1216535862.19656.845.camel@ebony.2ndQuadrant> <20080720214335.GB18846@tamriel.snowman.net> <1216591180.19656.848.camel@ebony.2ndQuadrant> <20080721011829.GC18846@tamriel.snowman.net> Content-Type: text/plain Date: Mon, 21 Jul 2008 07:11:27 +0100 Message-Id: <1216620687.19656.860.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200807/199 X-Sequence-Number: 6893 On Sun, 2008-07-20 at 21:18 -0400, Stephen Frost wrote: > * Simon Riggs (simon@2ndquadrant.com) wrote: > > On Sun, 2008-07-20 at 17:43 -0400, Stephen Frost wrote: > > > Even this doesn't cover everything though- it's too focused on tables > > > and data loading. Where do functions go? What about types? > > > > Yes, it is focused on tables and data loading. What about > > functions/types? No relevance here. > > I don't see how they're not relevant, it's not like they're being > excluded and in fact they show up in the pre-load output. Heck, even if > they *were* excluded, that should be made clear in the documentation > (either be an explicit include list, or saying they're excluded). > > Part of what's driving this is making sure we have a plan for future > objects and where they'll go. Perhaps it would be enough to just say > "pre-load is everything in the schema, except things which are faster > done in bulk (eg: indexes, keys)". I don't think it's right to say > pre-load is "only object definitions required to load data" when it > includes functions and ACLs though. > > Hopefully my suggestion and these comments will get us to a happy > middle-ground. I don't really understand what you're saying. The options split the dump into 3 parts that's all: before the load, the load and after the load. --schema-pre-load says "Dumps exactly what