Received: from localhost (unknown [200.46.204.183])
	by postgresql.org (Postfix) with ESMTP id DC14F6501CA;
	Fri, 25 Jul 2008 16:39:51 -0300 (ADT)
Received: from postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 46709-05; Fri, 25 Jul 2008 16:39:46 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from mk-outboundfilter-3.mail.uk.tiscali.com
	(mk-outboundfilter-3.mail.uk.tiscali.com [212.74.114.23])
	by postgresql.org (Postfix) with ESMTP id 4071064FCFD;
	Fri, 25 Jul 2008 16:39:48 -0300 (ADT)
X-Trace: 
 149342350/mk-outboundfilter-1.mail.uk.tiscali.com/F2S/$F2S-NILDRAM-ACCEPTED/f2s-temporary-group/85.211.229.155
X-SBRS: None
X-RemoteIP: 85.211.229.155
X-IP-MAIL-FROM: simon@2ndquadrant.com
X-IP-BHB: Once
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AkcBAPDIiUhV0+Wb/2dsb2JhbAAIsBw
X-IronPort-AV: E=Sophos;i="4.31,253,1215385200"; d="scan'208";a="149342350"
X-IP-Direction: IN
Received: from 85-211-229-155.dyn.gotadsl.co.uk (HELO [192.168.0.3])
	([85.211.229.155])
	by smtp.f2s.tiscali.co.uk with ESMTP; 25 Jul 2008 20:39:45 +0100
Subject: Re: [PATCHES] odd output in restore mode
From: Simon Riggs <simon@2ndquadrant.com>
To: Martin Zaun <Martin.Zaun@Sun.COM>
Cc: Bruce Momjian <bruce@momjian.us>,
	Heikki Linnakangas <heikki@enterprisedb.com>,
	Andrew Dunstan <andrew@dunslane.net>, Dave Page <dpage@pgadmin.org>,
	List pgsql-patches <pgsql-patches@postgresql.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
In-Reply-To: <48867904.9090001@sun.com>
References: <200807011520.m61FKhZ20311@momjian.us> <48867904.9090001@sun.com>
Content-Type: text/plain
Date: Fri, 25 Jul 2008 20:46:18 +0100
Message-Id: <1217015178.3894.992.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.0 
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200807/1207
X-Sequence-Number: 121467


On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:

> reviewing your patch 

Current status is this:

* My understanding is that Dave and Andrew (and therefore Simon) think
the approach proposed here is an acceptable one. Heikki disagrees and
wants different approach. Perhaps I misunderstand.

* Patch needs work to complete the proposed approach

* I'm willing to change the patch, but not able to test it on Windows.

Is there someone able to test the patch, if I make the changes? If not,
we should just kick this out of the CommitFest queue now and be done. If
nobody cares enough about this issue to test a fix, we shouldn't bother.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support