Subject: Re: [HACKERS] Infrastructure changes for recovery
From: Simon Riggs <simon@2ndQuadrant.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	List pgsql-patches <pgsql-patches@postgresql.org>
In-Reply-To: <20080912181421.GI8854@alvh.no-ip.org>
References: <1218109459.4549.423.camel@ebony.2ndQuadrant>
	<1220213074.4371.173.camel@ebony.2ndQuadrant>
	<1905.1220895241@sss.pgh.pa.us>
	<1221080797.3913.768.camel@ebony.2ndQuadrant>
	<20080912181421.GI8854@alvh.no-ip.org>
Content-Type: text/plain
Date: Fri, 12 Sep 2008 19:56:06 +0100
Message-Id: <1221245766.3913.1130.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
> Simon Riggs wrote:
> 
> > --- 5716,5725 ----
> >   						CheckpointStats.ckpt_sync_end_t,
> >   						&sync_secs, &sync_usecs);
> >   
> > ! 	elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
> >   		 "%d transaction log file(s) added, %d removed, %d recycled; "
> >   		 "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
> > + 		 (checkpoint ? "  checkpoint" : "restartpoint"),
> >   		 CheckpointStats.ckpt_bufs_written,
> >   		 (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
> >   		 CheckpointStats.ckpt_segs_added,
> 
> Very minor nit: this really needs a rework.  

All I changed was the word "restartpoint"... its otherwise identical to
existing message. I'd rather not change that.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support