Subject: Re: [PATCHES] Infrastructure changes for recovery (v8)
From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <492176E2.1000006@enterprisedb.com>
References: <1222815151.4445.1397.camel@ebony.2ndQuadrant>
	<48EC9CC5.6060803@enterprisedb.com>
	<1223468660.4747.294.camel@ebony.2ndQuadrant>
	<1223472898.4747.310.camel@ebony.2ndQuadrant>
	<492176E2.1000006@enterprisedb.com>
Content-Type: text/plain
Date: Mon, 17 Nov 2008 15:31:16 +0000
Message-Id: <1226935876.3790.10.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Mon, 2008-11-17 at 15:51 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > diff --git a/src/backend/access/transam/subtrans.c b/src/backend/access/transam/
> > index 063b366..5e64cb4 100644
> > --- a/src/backend/access/transam/subtrans.c
> > +++ b/src/backend/access/transam/subtrans.c
> > @@ -226,6 +226,9 @@ ZeroSUBTRANSPage(int pageno)
> >   *
> >   * oldestActiveXID is the oldest XID of any prepared transaction, or nextXid
> >   * if there are none.
> > + *
> > + * Note that this is not atomic and is not yet safe to perform while other
> > + * processes might access subtrans.
> >   */
> >  void
> >  StartupSUBTRANS(TransactionId oldestActiveXID)
> 
> I'm a bit confused by that comment. Does that need to be fixed? 

It is, in a later version. Apologies if you're reviewing the wrong one.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support