Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 77F6164FD2B for ; Thu, 20 Nov 2008 06:09:39 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 95075-04 for ; Thu, 20 Nov 2008 06:09:36 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail137070.authsmtp.co.uk (outmail137070.authsmtp.co.uk [62.13.137.70]) by mail.postgresql.org (Postfix) with ESMTP id 8C1B564FD1A for ; Thu, 20 Nov 2008 06:09:36 -0400 (AST) Received: from mail-c187.authsmtp.com (mail-c187.authsmtp.com [62.13.128.33]) by punt5.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id mAKA92fN004675; Thu, 20 Nov 2008 10:09:02 GMT Received: from [192.168.1.104] (static-217-133-9-61.clienti.tiscali.it [217.133.9.61]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id mAKA90IG085529; Thu, 20 Nov 2008 10:09:00 GMT Subject: Re: [PATCHES] Infrastructure changes for recovery (v8) From: Simon Riggs To: Pavan Deolasee Cc: Heikki Linnakangas , pgsql-hackers In-Reply-To: <2e78013d0811200149t29173598m5eb70f62c1dc02d4@mail.gmail.com> References: <1222815151.4445.1397.camel@ebony.2ndQuadrant> <48EC9CC5.6060803@enterprisedb.com> <1223468660.4747.294.camel@ebony.2ndQuadrant> <1223472898.4747.310.camel@ebony.2ndQuadrant> <492176E2.1000006@enterprisedb.com> <1226935876.3790.10.camel@ebony.2ndQuadrant> <2e78013d0811192136o5b722ddyb1562658508dcc5a@mail.gmail.com> <1227174122.7015.5.camel@ebony.2ndQuadrant> <2e78013d0811200149t29173598m5eb70f62c1dc02d4@mail.gmail.com> Content-Type: text/plain Date: Thu, 20 Nov 2008 10:10:05 +0000 Message-Id: <1227175805.7015.22.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Server-Quench: 40e4a81c-b6eb-11dd-8155-001185d377ca X-AuthRoute: OCdxZQATClZOTQEd DAteCiNZVAwpPBRK HVkIKg5MJUcNSQVJ NksadRtFagVbY1ZH HGQLW1xEUV17WWp/ awsfbwRafEtNXBtj Tk5IXVBXFgB3AVJc d2VvWxkLAAVOfXty bAhjXXdZEkB6IEIs Sk8HCD8AMDV9aWFL BF1QdgZRbQNKfx5N bwR8U3ReMCtlM3Bw LC8aFBMcBw5qYBdt az0mDX8pdA4qGDAm TgseBygkAVAfSm04 LxUgJVMHVEgWKA0o PFAmR18CIldSFF0f d2l0 X-Authentic-SMTP: 61633235383639.squirrel.dmpriest.net.uk:1378/Kp X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200811/1334 X-Sequence-Number: 128046 On Thu, 2008-11-20 at 15:19 +0530, Pavan Deolasee wrote: > Do you intend to split the patch into smaller pieces ? The latest hot > standby patch is almost 10K+ lines. Splitting that would definitely > help the review process. If it helps you, then I'll do it. Hang on an hour or so. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support