Subject: Re: [PATCHES] Infrastructure changes for recovery (v8)
From: Simon Riggs <simon@2ndQuadrant.com>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <1227175805.7015.22.camel@ebony.2ndQuadrant>
References: <1222815151.4445.1397.camel@ebony.2ndQuadrant>
	<48EC9CC5.6060803@enterprisedb.com>
	<1223468660.4747.294.camel@ebony.2ndQuadrant>
	<1223472898.4747.310.camel@ebony.2ndQuadrant>
	<492176E2.1000006@enterprisedb.com>
	<1226935876.3790.10.camel@ebony.2ndQuadrant>
	<2e78013d0811192136o5b722ddyb1562658508dcc5a@mail.gmail.com>
	<1227174122.7015.5.camel@ebony.2ndQuadrant>
	<2e78013d0811200149t29173598m5eb70f62c1dc02d4@mail.gmail.com>
	<1227175805.7015.22.camel@ebony.2ndQuadrant>
Content-Type: text/plain
Date: Thu, 18 Dec 2008 01:31:21 +0000
Message-Id: <1229563881.4793.264.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Thu, 2008-11-20 at 10:10 +0000, Simon Riggs wrote:
> On Thu, 2008-11-20 at 15:19 +0530, Pavan Deolasee wrote:
> 
> > Do you intend to split the patch into smaller pieces ? The latest hot
> > standby patch is almost 10K+ lines. Splitting that would definitely
> > help the review process.
> 
> If it helps you, then I'll do it. Hang on an hour or so.

I've posted a slightly subdivided patch now via Wiki.

Putting "infrastructure" and "hot standby" together was fairly easy, but
splitting them apart has not been and I was unable to complete that
after a lot of hacking. 

If you wouldn't mind looking at the major subsystems some more, I'm
happy to attempt some further parceling to make it easier for you to
review. I'm not completely certain the "infra" v "hot standby" is a good
split point anyway.

Please let me know how I can make the reviewer's job easier. Diagrams,
writeups, whatever. Thanks,

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support