Subject: Re: [PATCHES] Infrastructure changes for recovery (v8)
From: Simon Riggs <simon@2ndQuadrant.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <20081218023212.GO4453@alvh.no-ip.org>
References: <48EC9CC5.6060803@enterprisedb.com>
	<1223468660.4747.294.camel@ebony.2ndQuadrant>
	<1223472898.4747.310.camel@ebony.2ndQuadrant>
	<492176E2.1000006@enterprisedb.com>
	<1226935876.3790.10.camel@ebony.2ndQuadrant>
	<2e78013d0811192136o5b722ddyb1562658508dcc5a@mail.gmail.com>
	<1227174122.7015.5.camel@ebony.2ndQuadrant>
	<2e78013d0811200149t29173598m5eb70f62c1dc02d4@mail.gmail.com>
	<1227175805.7015.22.camel@ebony.2ndQuadrant>
	<1229563881.4793.264.camel@ebony.2ndQuadrant>
	<20081218023212.GO4453@alvh.no-ip.org>
Content-Type: text/plain; charset=utf-8
Date: Thu, 18 Dec 2008 02:50:49 +0000
Message-Id: <1229568649.4793.296.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit


On Wed, 2008-12-17 at 23:32 -0300, Alvaro Herrera wrote:
> Simon Riggs escribió:
> 
> > Please let me know how I can make the reviewer's job easier. Diagrams,
> > writeups, whatever. Thanks,
> 
> A link perhaps?

There is much confusion on this point for which I'm very sorry.

I originally wrote "infra" patch to allow it to be committed separately
in the Sept commitfest, to reduce size of the forthcoming hotstandby
patch. That didn't happen (no moans there) so the eventual "hotstandby"
patch includes all of what was the infra patch, plus the new code.

So currently there is no separate "infra" patch. The two line items on
the CommitFest page are really just one large project. I would be in
favour of removing the "infra" lines from the CommitFest page. 

Of course we can consider "hotstandby" patch in parts, but
deconstructing it into wholly separate patches doesn't make much sense
now and would raise many questions about why certain code exists with no
apparent function or why certain design choices made.

If you were to review a part of this, I might ask that you look at the
changes to XidInMVCCSnapshot(), GetSnapshotData() and
AssignTransactionId(), which relate specifically to subtransaction
handling. Comments explain the new approach.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support