Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id 9B68663254A
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Wed, 21 Jan 2009 14:19:26 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 84248-04-6
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Wed, 21 Jan 2009 14:18:06 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30])
	by mail.postgresql.org (Postfix) with ESMTP id 8529F63259D
	for <pgsql-hackers@postgresql.org>;
	Wed, 21 Jan 2009 14:08:22 -0400 (AST)
Received: by yx-out-2324.google.com with SMTP id 8so1576666yxb.73
	for <pgsql-hackers@postgresql.org>;
	Wed, 21 Jan 2009 10:08:21 -0800 (PST)
Received: by 10.142.142.16 with SMTP id p16mr3454535wfd.321.1232561300653;
	Wed, 21 Jan 2009 10:08:20 -0800 (PST)
Received: from ?192.168.1.10? (c-67-188-158-142.hsd1.ca.comcast.net
	[67.188.158.142])
	by mx.google.com with ESMTPS id 32sm16841315wfa.40.2009.01.21.10.08.18
	(version=SSLv3 cipher=RC4-MD5); Wed, 21 Jan 2009 10:08:19 -0800 (PST)
Subject: Re: [PATCHES] GIN improvements
From: Jeff Davis <pgsql@j-davis.com>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Pgsql Hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <49770FD4.5030600@sigaev.ru>
References: <483FD205.4090904@sigaev.ru> <486BC501.6060605@sigaev.ru>
	<27880.1215810535@sss.pgh.pa.us> <487A6E0C.3090600@sigaev.ru>
	<8993.1216843701@sss.pgh.pa.us> <4888A594.6010102@sigaev.ru>
	<490B07BA.6030109@sigaev.ru> <492F04D9.5070404@enterprisedb.com>
	<4942A137.3000502@sigaev.ru> <1229910966.2285.76.camel@jdavis>
	<49708008.8070109@sigaev.ru> <1232348905.7281.114.camel@jdavis>
	<4974B002.3040202@sigaev.ru> <1232474489.23316.8.camel@jdavis>
	<49770FD4.5030600@sigaev.ru>
Content-Type: text/plain
Date: Wed, 21 Jan 2009 10:07:51 -0800
Message-Id: <1232561271.23793.46.camel@jdavis>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=2.125 tagged_above=0 required=5
	tests=DNS_FROM_RFC_BOGUSMX=2.125
X-Spam-Level: **
X-Archive-Number: 200901/1545
X-Sequence-Number: 132189

On Wed, 2009-01-21 at 15:06 +0300, Teodor Sigaev wrote:
> Done. Now GIN counts number of pending tuples and pages and stores they on 
> metapage. Index cleanup could start during normal insertion in two cases:
> - number of pending tuples is too high to keep guaranteed non-lossy tidbitmap
> - pending page's content doesn't fit into work_mem.

Great, thanks. I will take a look at this version tonight.

Because time is short, I will mark it as "Ready for committer review"
now. I think all of the major issues have been addressed, and I'll just
be looking at the code and testing it.

> BTW, gincostestimate could use that information for cost estimation, but is 
> index opening and metapge reading in amcostestimate acceptable?

That sounds reasonable to me. I think that's what the index-specific
cost estimators are for. Do you expect a performance impact?

Regards,
	Jeff Davis