To: Andrew Chernow <ac@esilo.com>
cc: Merlin Moncure <mmoncure@gmail.com>, Andrew Dunstan <andrew@dunslane.net>,
	Alvaro Herrera <alvherre@commandprompt.com>,
	"Patches (PostgreSQL)" <pgsql-patches@postgresql.org>
Subject: Re: libpq object hooks (libpq events) 
In-reply-to: <48323593.4060302@esilo.com> 
References: <b42b73150804301323i18b00019i62e765708abb65aa@mail.gmail.com>
	<482A58D8.2030205@dunslane.net>
	<20080514043313.GS6966@alvh.no-ip.org>
	<482AD896.4000504@dunslane.net> <19342.1210776271@sss.pgh.pa.us>
	<b42b73150805140921v30d24b75m6c230932c61ffdd2@mail.gmail.com>
	<482B1480.1070705@esilo.com> <482B2AC5.7000503@esilo.com>
	<482ECF62.7010901@esilo.com> <12200.1211242959@sss.pgh.pa.us>
	<48323593.4060302@esilo.com>
Comments: In-reply-to Andrew Chernow <ac@esilo.com>
	message dated "Mon, 19 May 2008 22:21:07 -0400"
Date: Mon, 19 May 2008 22:37:58 -0400
Message-ID: <13642.1211251078@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Andrew Chernow <ac@esilo.com> writes:
> 4. add a setter for result instance data
>    - There should also be a PQsetInstanceData(PGconn*, ...)
>    - I see no need for a passThrough setter

Check, though I assume we're not expecting PQsetInstanceData to
propagate to previously created PGresults?

> 5. move callback stuff to its own header, maybe pgcallback.h?

Should be libpq-something.  I was considering libpq-hooks.h or
libpq-events.h, but libpq-callback.h would be OK too.

> Adding PQresultSetInstanceData doesn't removes the need for a resultcreate 
> callback event.

No, of course not.  What I was imagining was that the resultcreate
callback would call PQresultSetInstanceData.

			regards, tom lane