Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 5C28337C47B for ; Tue, 7 Oct 2008 12:13:57 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 19497-01 for ; Tue, 7 Oct 2008 12:13:47 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 40C9B37C272 for ; Tue, 7 Oct 2008 12:11:04 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m97F5j02014678; Tue, 7 Oct 2008 11:05:46 -0400 (EDT) To: "Robert Haas" cc: "Alvaro Herrera" , "Simon Riggs" , "Andrew Dunstan" , pgsql-hackers Subject: Re: [PATCHES] Infrastructure changes for recovery In-reply-to: <603c8f070810070746mdec86f7o8721dd1a8374ae94@mail.gmail.com> References: <1221745847.3913.2408.camel@ebony.2ndQuadrant> <1222121161.4445.248.camel@ebony.2ndQuadrant> <1222184541.4445.400.camel@ebony.2ndQuadrant> <28973.1222381719@sss.pgh.pa.us> <1222985488.4445.1625.camel@ebony.2ndQuadrant> <48E5544B.5050103@dunslane.net> <1223367445.4747.105.camel@ebony.2ndQuadrant> <13866.1223388527@sss.pgh.pa.us> <1223389637.4747.194.camel@ebony.2ndQuadrant> <20081007143707.GA19440@alvh.no-ip.org> <603c8f070810070746mdec86f7o8721dd1a8374ae94@mail.gmail.com> Comments: In-reply-to "Robert Haas" message dated "Tue, 07 Oct 2008 10:46:28 -0400" Date: Tue, 07 Oct 2008 11:05:45 -0400 Message-ID: <14677.1223391945@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200810/264 X-Sequence-Number: 125281 "Robert Haas" writes: >>> I'm just grumpy because I can't see a way to do the >>> patch-on-patch-on-patch that I'll need to make this all work for Nov 1. >>> So big patch here we come. But that's just the way it is and I'll stop >>> honking about it. >> >> This is one of the problems that DVCSs are supposed to solve ... have >> you tried Git? > I think the other problem here is that the difficulty of getting the > patch landed increases more than linearly with its size. Yeah. Tools aren't really the key problem there IMHO. I agree with Simon that it would be a good thing if this patch got landed before he went on to the next part. But personally I'm a bit burned out from commitfest and am not eager to go take a third look at the patch right now. Does anyone else want to review it? regards, tom lane