Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 972E1650004 for ; Mon, 8 Sep 2008 11:49:34 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 35382-05 for ; Mon, 8 Sep 2008 11:49:24 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 7217164FD1C for ; Mon, 8 Sep 2008 11:49:23 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m88EnIMl014977; Mon, 8 Sep 2008 10:49:18 -0400 (EDT) To: Zdenek Kotala cc: Alex Hunsaker , Xiao Meng , pgsql-patches@postgresql.org, "Jonah H. Harris" Subject: Re: hash index improving v3 In-reply-to: <48C5349F.4080300@sun.com> References: <7627.1220569888@sss.pgh.pa.us> <34d269d40809041742r6a0703dbgfbdd012f7f19de2e@mail.gmail.com> <10995.1220577198@sss.pgh.pa.us> <11525.1220579153@sss.pgh.pa.us> <34d269d40809041854g355a8f68ga3a037a69e3d9fcb@mail.gmail.com> <11962.1220581027@sss.pgh.pa.us> <34d269d40809042048m3b532a5ej7a9588f63a788d0c@mail.gmail.com> <34d269d40809050912u33f2afc8mb90e316bc465136e@mail.gmail.com> <34d269d40809051321w2ed16037od0373a4a29c311f1@mail.gmail.com> <34d269d40809052249h59750f83v4b19a50d0555580@mail.gmail.com> <22574.1220728178@sss.pgh.pa.us> <48C5349F.4080300@sun.com> Comments: In-reply-to Zdenek Kotala message dated "Mon, 08 Sep 2008 16:20:15 +0200" Date: Mon, 08 Sep 2008 10:49:18 -0400 Message-ID: <14976.1220885358@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/93 X-Sequence-Number: 7108 Zdenek Kotala writes: > I attach cleanup patch which we discussed last commit fest. It introduce new > macros HashGetMetaPage and HashGetBitmap and of course, it break backward on > disk format compatibility which we will break it anyway when Xiao's patch will > be committed. If we accept that patch, I'm okay with including this one too. Still hoping for some performance testing though. (Note that this one isn't going to affect performance, so no need to include it for that purpose.) regards, tom lane