Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id C411065011F for ; Wed, 23 Jul 2008 12:05:39 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 72349-05 for ; Wed, 23 Jul 2008 12:05:37 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id D87F4650115 for ; Wed, 23 Jul 2008 12:05:36 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m6NF5afr015379; Wed, 23 Jul 2008 11:05:36 -0400 (EDT) To: Teodor Sigaev cc: Oleg Bartunov , Pgsql Hackers Subject: Re: [PATCHES] GIN improvements In-reply-to: <488734A5.9030503@sigaev.ru> References: <483FD205.4090904@sigaev.ru> <486BC501.6060605@sigaev.ru> <27880.1215810535@sss.pgh.pa.us> <487A6E0C.3090600@sigaev.ru> <29437.1216742605@sss.pgh.pa.us> <48861758.4070507@sigaev.ru> <1636.1216749010@sss.pgh.pa.us> <488625E8.4070203@sigaev.ru> <2818.1216753264@sss.pgh.pa.us> <488734A5.9030503@sigaev.ru> Comments: In-reply-to Teodor Sigaev message dated "Wed, 23 Jul 2008 17:39:49 +0400" Date: Wed, 23 Jul 2008 11:05:35 -0400 Message-ID: <15378.1216825535@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200807/1069 X-Sequence-Number: 121329 Teodor Sigaev writes: > So, may be we just move insertcleanup call to ginbulkdelete/ginvacuumcleanup > but leave aminsertcleanup field in pg_proc for a future. I'd be inclined not to add the extra AM call if we aren't going to use it now. There's no very good reason to think that a definition we settled on today would be exactly the right thing for whatever future need might appear. Better to wait till we have a concrete example to design around. regards, tom lane