Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 4C23965017F for ; Mon, 21 Jul 2008 17:34:16 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 95102-08 for ; Mon, 21 Jul 2008 17:34:09 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 2EDA064FCD8 for ; Mon, 21 Jul 2008 17:34:12 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m6LKXtwj017501; Mon, 21 Jul 2008 16:33:55 -0400 (EDT) To: Simon Riggs cc: Pavan Deolasee , List pgsql-patches Subject: Re: [HACKERS] Hint Bits and Write I/O In-reply-to: <1216670891.3894.34.camel@ebony.2ndQuadrant> References: <1211916951.4489.232.camel@ebony.site> <15901.1211931165@sss.pgh.pa.us> <1213797209.9468.126.camel@ebony.site> <87hcbfq71p.fsf@oxford.xeocode.com> <1214578938.3845.423.camel@ebony.site> <1214865781.3845.525.camel@ebony.site> <2e78013d0807202306t21ff41a9q53673dc9a48bf859@mail.gmail.com> <1216670891.3894.34.camel@ebony.2ndQuadrant> Comments: In-reply-to Simon Riggs message dated "Mon, 21 Jul 2008 21:08:11 +0100" Date: Mon, 21 Jul 2008 16:33:55 -0400 Message-ID: <17500.1216672435@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200807/216 X-Sequence-Number: 6910 Simon Riggs writes: > On Mon, 2008-07-21 at 11:36 +0530, Pavan Deolasee wrote: >> I think we should try at least one or two possible optimizations and >> get some numbers before we jump and make substantial changes to the >> code. > You know you're suggesting months of tests and further discussion. :-( I agree with Pavan that we should have something that'd at least serve as test scaffolding to verify that the framework patch is sane. The test code needn't be anything we'd want to commit. It seems like largely the same kind of issue as with your stats-hooks patch. regards, tom lane