Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id 9132364FC52
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 24 Nov 2008 11:45:27 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 44577-08
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 24 Nov 2008 11:45:24 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id 7A48E64FC40
	for <pgsql-hackers@postgresql.org>;
	Mon, 24 Nov 2008 11:45:24 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id mAOFifMb001927;
	Mon, 24 Nov 2008 10:44:41 -0500 (EST)
To: Gregory Stark <stark@enterprisedb.com>
cc: Magnus Hagander <magnus@hagander.net>,
	Hiroshi Saito <z-saito@guitar.ocn.ne.jp>,
	ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>,
	Jaime Casanova <jcasanov@systemguards.com.ec>,
	Alvaro Herrera <alvherre@commandprompt.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] Solve a problem of LC_TIME of windows. 
In-reply-to: <87hc5xrvl9.fsf@oxford.xeocode.com> 
References: <20081104094301.7EE8.52131E4D@oss.ntt.co.jp>
	<3073cc9b0811102212n278644a8o7169f7c5ea562081@mail.gmail.com>
	<20081111152112.B605.52131E4D@oss.ntt.co.jp>
	<A32F4AB7D95646B3A358002E1FB73F9C@HIRO57887DE653>
	<446F4763B989489C9B626D21AB9F6C7F@HIRO57887DE653>
	<492AA5CD.8050001@hagander.net> <18269.1227538234@sss.pgh.pa.us>
	<87hc5xrvl9.fsf@oxford.xeocode.com>
Comments: In-reply-to Gregory Stark <stark@enterprisedb.com>
	message dated "Mon, 24 Nov 2008 15:29:22 +0000"
Date: Mon, 24 Nov 2008 10:44:40 -0500
Message-ID: <1926.1227541480@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200811/1582
X-Sequence-Number: 128294

Gregory Stark <stark@enterprisedb.com> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Please stick to the convention of including include files in
>> alphabetical order.

> I didn't realize we had such a convention. Is this for all include files or
> only within a directory? Are there exceptions where the order matters or have
> we managed to make sure it doesn't everywhere?

If the order matters, it's a bug in the include files.  Bruce runs a
script periodically to check that no include file depends on anything
except postgres.h (or postgres_fe.h, as appropriate).

			regards, tom lane