Date: Thu, 3 Jul 2008 05:55:01 -0700
From: daveg <daveg@sonic.net>
To: Marko Kreen <markokr@gmail.com>
Cc: pgsql-patches@postgresql.org, hari@efrontier.com,
	Postgres Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] pg_dump lock timeout
Message-ID: <20080703125501.GS866@sonic.net>
References: <20080511113047.GV5673@sonic.net>
	<e51f66da0807030115y2520ecbdie9d17f6312636f3@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e51f66da0807030115y2520ecbdie9d17f6312636f3@mail.gmail.com>
User-Agent: Mutt/1.4.2.1i

On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote:
> On 5/11/08, daveg <daveg@sonic.net> wrote:
> >  Attached is a patch to add a commandline option to pg_dump to limit how long
> >  pg_dump will wait for locks during startup.
> 
> My quick review:
> 
> - It does not seem important enough to waste a short option on.
>   Having only long option should be enough.

Agreed. I'll change it.
 
> - It would be more polite to do SET LOCAL instead SET.
>   (Eg. it makes safer to use pg_dump through pooler.)

Also agreed. Thanks.

> - The statement_timeout is set back with "statement_timeout = default"
>   Maybe it would be better to do "= 0" here?  Although such decision
>   would go outside the scope of the patch, I see no sense having
>   any other statement_timeout for actual dumping.

I'd prefer to leave whatever policy is otherwise in place alone. I can see
use cases for either having or not having a timeout for pg_dump, but it does
seem  outside the scope of this patch.

Thanks for you review and comments.

-dg

-- 
David Gould       daveg@sonic.net      510 536 1443    510 282 0869
If simplicity worked, the world would be overrun with insects.