Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 53BAD650186; Mon, 7 Jul 2008 11:03:52 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 10404-10; Mon, 7 Jul 2008 11:03:43 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from lists.commandprompt.com (host-159.commandprompt.net [207.173.203.159]) by postgresql.org (Postfix) with ESMTP id 51B0E65017E; Mon, 7 Jul 2008 11:03:47 -0300 (ADT) Received: from perhan.alvh.no-ip.org (190-95-31-93.bk17-dsl.surnet.cl [190.95.31.93]) (authenticated bits=0) by lists.commandprompt.com (8.13.8/8.13.8) with ESMTP id m67E5qtx030608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Jul 2008 07:05:55 -0700 Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id EB59A47C7C; Mon, 7 Jul 2008 10:03:40 -0400 (CLT) Date: Mon, 7 Jul 2008 10:03:40 -0400 From: Alvaro Herrera To: Teodor Sigaev Cc: Patches , Pgsql Hackers Subject: Re: [PATCHES] GIN improvements Message-ID: <20080707140340.GD21091@alvh.no-ip.org> References: <483FD205.4090904@sigaev.ru> <486BC501.6060605@sigaev.ru> <20080707134533.GB21091@alvh.no-ip.org> <487220F9.4010403@sigaev.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <487220F9.4010403@sigaev.ru> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (lists.commandprompt.com [207.173.203.159]); Mon, 07 Jul 2008 07:05:55 -0700 (PDT) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200807/279 X-Sequence-Number: 120539 Teodor Sigaev wrote: >> I looked this over and it looks good in general. I was only wondering >> about for single-column indexes -- we're storing attribute numbers too, >> right? > No, GinState->oneCol field signals to GinFormTuple and > gin_index_getattr/gintuple_get_attrnum about actual storage. > > Single column index is binary compatible with current index :) Ah, neat! -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support