Date: Sat, 19 Jul 2008 23:07:49 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-patches@postgresql.org
Subject: pg_dump additional options for performance
Message-ID: <20080720030749.GA18846@tamriel.snowman.net>
Mail-Followup-To: Simon Riggs <simon@2ndquadrant.com>,
	pgsql-patches@postgresql.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0"
Content-Disposition: inline
User-Agent: Mutt/1.5.18 (2008-05-17)


--k+w/mQv8wyuph6w0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Simon,

  I agree with adding these options in general, since I find myself
  frustrated by having to vi huge dumps to change simple schema things.
  A couple of comments on the patch though:

  - Conflicting option handling
    I think we are doing our users a disservice by putting it on them to
	figure out exactly what:
	multiple object groups cannot be used together
	means to them.  You and I may understand what an "object group" is,
	and why there can be only one, but it's a great deal less clear than
	the prior message of
	options -s/--schema-only and -a/--data-only cannot be used together
	My suggestion would be to either list out the specific options which
	can't be used together, as was done previously, or add a bit of (I
	realize, boring) code and actually tell the user which of the
	conflicting options were used.

  - Documentation
	When writing the documentation I would stress that "pre-schema" and
	"post-schema" be defined in terms of PostgreSQL objects and why they
	are pre vs. post.

  - Technically, the patch needs to be updated slightly since another
	pg_dump-related patch was committed recently which also added
	options and thus causes a conflict.

  Beyond those minor points, the patch looks good to me.

  	Thanks,

		Stephen

--k+w/mQv8wyuph6w0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiCrAUACgkQrzgMPqB3kih3rwCeOqBtCUUM3iIwmtpY9IYb2dcT
SJIAmwfTsBM8P8fvGRbSKOOYEqPe90NJ
=MKZP
-----END PGP SIGNATURE-----

--k+w/mQv8wyuph6w0--