Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id B5CE864FF8A for ; Wed, 3 Sep 2008 14:03:00 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 07254-02 for ; Wed, 3 Sep 2008 14:02:57 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from lists.commandprompt.com (host-159.commandprompt.net [207.173.203.159]) by postgresql.org (Postfix) with ESMTP id 7ECF364FF57 for ; Wed, 3 Sep 2008 14:02:56 -0300 (ADT) Received: from perhan.alvh.no-ip.org (200-126-66-230.bk5-dsl.surnet.cl [200.126.66.230]) (authenticated bits=0) by lists.commandprompt.com (8.13.8/8.13.8) with ESMTP id m83H64ur008892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Sep 2008 10:06:07 -0700 Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id F325447CA7; Wed, 3 Sep 2008 13:02:49 -0400 (CLT) Date: Wed, 3 Sep 2008 13:02:49 -0400 From: Alvaro Herrera To: Andrew Chernow Cc: "Patches (PostgreSQL)" Subject: Re: libpq events patch Message-ID: <20080903170249.GC4114@alvh.no-ip.org> References: <482B2AC5.7000503@esilo.com> <482ECF62.7010901@esilo.com> <12200.1211242959@sss.pgh.pa.us> <48323593.4060302@esilo.com> <13642.1211251078@sss.pgh.pa.us> <48323F94.6010201@esilo.com> <48325386.2010506@esilo.com> <20080903001920.GT12610@alvh.no-ip.org> <48BE9AA0.1070606@esilo.com> <48BEBAC3.7060701@esilo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48BEBAC3.7060701@esilo.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (lists.commandprompt.com [207.173.203.159]); Wed, 03 Sep 2008 10:06:08 -0700 (PDT) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/32 X-Sequence-Number: 7047 Andrew Chernow wrote: > This is an updated version pf the libpqevents patch. See > > http://archives.postgresql.org/pgsql-hackers/2008-09/msg00153.php > > for details. The only change I didn't make yet is the event 'name'. I > have put it in and taken it out twice now, so a firm 'put it in there' > would be appreciated. You didn't merge the other changes I did to your patch. Please use that one as starting point, or merge them into your version. They were minor, sure, but I went some lengths to make them, which means the code kinda has my signoff that way. Please don't waste that work. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support