Received: from localhost (unknown [200.46.204.183])
	by postgresql.org (Postfix) with ESMTP id AE6FC64FCBA
	for <pgsql-patches-postgresql.org@postgresql.org>;
	Sat,  6 Sep 2008 15:14:37 -0300 (ADT)
Received: from postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 20952-02 for
	<pgsql-patches-postgresql.org@postgresql.org>;
	Sat,  6 Sep 2008 15:14:34 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by postgresql.org (Postfix) with ESMTP id A7A2364FCBD
	for <pgsql-patches@postgresql.org>;
	Sat,  6 Sep 2008 15:14:32 -0300 (ADT)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m86IEQJT020928;
	Sat, 6 Sep 2008 14:14:26 -0400 (EDT)
To: "Alex Hunsaker" <badalex@gmail.com>
cc: "Xiao Meng" <mx.cogito@gmail.com>,
 "Zdenek Kotala" <Zdenek.Kotala@sun.com>,
	pgsql-patches@postgresql.org, "Jonah H. Harris" <jonah.harris@gmail.com>
Subject: Re: hash index improving v3 
In-reply-to: <34d269d40809052249h59750f83v4b19a50d0555580@mail.gmail.com> 
References: <ded849dd0808171846g2c6c65adub942bd2510a6c94f@mail.gmail.com>
	<7627.1220569888@sss.pgh.pa.us>
	<34d269d40809041742r6a0703dbgfbdd012f7f19de2e@mail.gmail.com>
	<10995.1220577198@sss.pgh.pa.us> <11525.1220579153@sss.pgh.pa.us>
	<34d269d40809041854g355a8f68ga3a037a69e3d9fcb@mail.gmail.com>
	<11962.1220581027@sss.pgh.pa.us>
	<34d269d40809042048m3b532a5ej7a9588f63a788d0c@mail.gmail.com>
	<34d269d40809050912u33f2afc8mb90e316bc465136e@mail.gmail.com>
	<34d269d40809051321w2ed16037od0373a4a29c311f1@mail.gmail.com>
	<34d269d40809052249h59750f83v4b19a50d0555580@mail.gmail.com>
Comments: In-reply-to "Alex Hunsaker" <badalex@gmail.com>
	message dated "Fri, 05 Sep 2008 23:49:05 -0600"
Date: Sat, 06 Sep 2008 14:14:26 -0400
Message-ID: <20927.1220724866@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200809/67
X-Sequence-Number: 7082

"Alex Hunsaker" <badalex@gmail.com> writes:
> - 			tbm_add_tuples(tbm, &scan->xs_ctup.t_self, 1, false);
> + 			tbm_add_tuples(tbm, &scan->xs_ctup.t_self, 1, true);

Hah, I bet that explains Jonah's complaint that recheck didn't seem to
be happening in his tests.  Nice catch.

			regards, tom lane