Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id E621464FD18 for ; Thu, 24 Jul 2008 04:54:24 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 59502-06 for ; Thu, 24 Jul 2008 04:54:18 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 78D3C64FD04 for ; Thu, 24 Jul 2008 04:54:17 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m6O7s1bi021688; Thu, 24 Jul 2008 03:54:01 -0400 (EDT) To: Simon Riggs cc: Stephen Frost , pgsql-patches@postgresql.org Subject: Re: pg_dump additional options for performance In-reply-to: <1216885031.3894.739.camel@ebony.2ndQuadrant> References: <20080720214335.GB18846@tamriel.snowman.net> <1216591180.19656.848.camel@ebony.2ndQuadrant> <20080721011829.GC18846@tamriel.snowman.net> <20080721014942.GC30869@sonic.net> <20080721015850.GD18846@tamriel.snowman.net> <18415.1216611275@sss.pgh.pa.us> <1216621040.19656.867.camel@ebony.2ndQuadrant> <20080721115602.GG18846@tamriel.snowman.net> <1216831237.3894.676.camel@ebony.2ndQuadrant> <1216832987.3894.678.camel@ebony.2ndQuadrant> <20080724032047.GI18846@tamriel.snowman.net> <1216885031.3894.739.camel@ebony.2ndQuadrant> Comments: In-reply-to Simon Riggs message dated "Thu, 24 Jul 2008 08:37:11 +0100" Date: Thu, 24 Jul 2008 03:54:01 -0400 Message-ID: <21687.1216886041@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200807/240 X-Sequence-Number: 6934 Simon Riggs writes: > [80k patch] Surely there is a whole lot of unintended noise in this patch? I certainly don't believe that you meant to change keywords.c for instance. regards, tom lane