To: Stephen Frost <sfrost@snowman.net>
cc: Simon Riggs <simon@2ndquadrant.com>, pgsql-patches@postgresql.org
Subject: Re: pg_dump additional options for performance 
In-reply-to: <20080726151110.GF16005@tamriel.snowman.net> 
References: <1216621040.19656.867.camel@ebony.2ndQuadrant>
	<20080721115602.GG18846@tamriel.snowman.net>
	<1216831237.3894.676.camel@ebony.2ndQuadrant>
	<1216832987.3894.678.camel@ebony.2ndQuadrant>
	<20080724032047.GI18846@tamriel.snowman.net>
	<1216885031.3894.739.camel@ebony.2ndQuadrant>
	<21687.1216886041@sss.pgh.pa.us>
	<1216889809.3894.747.camel@ebony.2ndQuadrant>
	<2818.1217027784@sss.pgh.pa.us>
	<1217063104.3894.1100.camel@ebony.2ndQuadrant>
	<20080726151110.GF16005@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Sat, 26 Jul 2008 11:11:10 -0400"
Date: Sat, 26 Jul 2008 12:24:07 -0400
Message-ID: <23580.1217089447@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Stephen Frost <sfrost@snowman.net> writes:
>>> Another issue is that the rules for deciding which objects are "before
>>> data" and which are "after data" are wrong.  In particular ACLs are after
>>> data not before data, which is relatively easy to fix.  
>> 
>> OK

> This was partially why I was complaining about having documentation, and
> a policy for that matter, which goes into more detail about why X is before
> or after the data.  I agree that they're after today, but I don't see
> any particular reason why they should be one or the other.

If a table's ACL revokes owner insert privilege, and was placed before
the data load steps, those steps would fail.  We are relying on the
default table privileges until we are done doing everything we need to
do to the tables (and perhaps other objects, I'm not sure if there are
any other comparable problems).

			regards, tom lane