Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 5F76B64FCF2 for ; Tue, 16 Sep 2008 23:42:15 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 38614-10 for ; Tue, 16 Sep 2008 23:42:12 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 7B35964FCE9 for ; Tue, 16 Sep 2008 23:42:12 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m8H2g6YM027616; Tue, 16 Sep 2008 22:42:06 -0400 (EDT) To: Andrew Chernow cc: Alvaro Herrera , PostgreSQL-development , Merlin Moncure Subject: Re: [PATCHES] libpq events patch (with sgml docs) In-reply-to: <48C19759.90402@esilo.com> References: <48C18533.2000204@esilo.com> <20080905192215.GK4353@alvh.no-ip.org> <48C18B48.509@esilo.com> <20080905194853.GL4353@alvh.no-ip.org> <48C191A7.3000205@esilo.com> <20080905201504.GM4353@alvh.no-ip.org> <48C19759.90402@esilo.com> Comments: In-reply-to Andrew Chernow message dated "Fri, 05 Sep 2008 16:32:25 -0400" Date: Tue, 16 Sep 2008 22:42:06 -0400 Message-ID: <27615.1221619326@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/1072 X-Sequence-Number: 124201 Andrew Chernow writes: > Missed that one. Good catch :) Update attached. Looking at this now. Question: why does PQgetResult invoke the RESULTCREATE event only for non-error results? This seems a rather odd asymmetry, particularly in view of the fact that a RESULTDESTROY event will occur for error results. And surely we do not need to micro-optimize error cases for speed. regards, tom lane