Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 44F6C650E9E for ; Thu, 3 Jul 2008 08:50:58 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 95486-09 for ; Thu, 3 Jul 2008 08:50:50 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29]) by postgresql.org (Postfix) with ESMTP id A0A2D650E8E for ; Thu, 3 Jul 2008 08:50:53 -0300 (ADT) Received: by yx-out-2324.google.com with SMTP id 8so199712yxb.73 for ; Thu, 03 Jul 2008 04:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=5wOWXY3+5xoTIOn1ZrMkIRLOf5tQ3oavcFy5KBr1tU8=; b=azgaAkojn5lTKfOg/MjppHFiOThGXYS3p5iPkql5Fg19nAqYkoDzbcd/uan7JqM990 CoVdpe792R4i6ReGlx2T+Man8RQ51o8+4lXefVqJbhq61lD45q7DfBjWbc9vxJfmGiPQ HRfOjaYpGfxOF8+R9I1xqI5blUrlw9PhAbY3s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=LoINoRIiuTRH5yBgREDpX5hLNBvmLA8exP6wsInO1PPrNgAX/H7VqhR+PmLb47Jpa3 qPV771GbPJATxvl3WIp9exWdYBad+sY1OrpLhzDb86RM2lj3mGHYOhyT9phQTIT7dcBO bbmKspwsaaNtQ5kOIdGbUW+Ob+WYKbPO0SMQY= Received: by 10.151.106.4 with SMTP id i4mr256533ybm.119.1215085852333; Thu, 03 Jul 2008 04:50:52 -0700 (PDT) Received: by 10.151.84.7 with HTTP; Thu, 3 Jul 2008 04:50:52 -0700 (PDT) Message-ID: <2e78013d0807030450m4cab60d0jd99d1acce59fae56@mail.gmail.com> Date: Thu, 3 Jul 2008 17:20:52 +0530 From: "Pavan Deolasee" To: "Zdenek Kotala" Subject: Re: page macros cleanup Cc: PostgreSQL-patches In-Reply-To: <48529B83.9010907@sun.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48529B83.9010907@sun.com> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200807/29 X-Sequence-Number: 6724 On Fri, Jun 13, 2008 at 9:38 PM, Zdenek Kotala wrote: > I attached code cleanup which is related to in-place upgrade. I replace > direct access to PageHeader structure with already existing macros and I > removed also unnecessary retyping. A quick review comment: One thing I noticed is that the modified definition of HashMaxItemSize now does not account for the size of ItemId which may not be the right thing. Please recheck that. Apart from that the patch looks good to me. As you said, we should probably replace the other direct usage of PageHeader with appropriate macros. Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com