Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 39B716507A6 for ; Fri, 11 Jul 2008 13:57:53 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 74504-02-3 for ; Fri, 11 Jul 2008 13:57:44 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from qb-out-1314.google.com (qb-out-1314.google.com [72.14.204.171]) by postgresql.org (Postfix) with ESMTP id 37B37650727 for ; Fri, 11 Jul 2008 13:57:40 -0300 (ADT) Received: by qb-out-1314.google.com with SMTP id f13so953285qba.28 for ; Fri, 11 Jul 2008 09:57:39 -0700 (PDT) Received: by 10.114.169.2 with SMTP id r2mr14222282wae.132.1215795457929; Fri, 11 Jul 2008 09:57:37 -0700 (PDT) Received: by 10.141.51.11 with HTTP; Fri, 11 Jul 2008 09:57:37 -0700 (PDT) Message-ID: <3073cc9b0807110957w71869487p17fb58cb98abc520@mail.gmail.com> Date: Fri, 11 Jul 2008 11:57:37 -0500 From: "Jaime Casanova" To: "Abhijit Menon-Sen" Subject: Re: Extending grant insert on tables to sequences Cc: "Alvaro Herrera" , "Jaime Casanova" , pgsql-hackers@postgresql.org In-Reply-To: <20080710031140.GA427@toroid.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_18308_20526414.1215795457922" References: <20080708133244.GB4095@alvh.no-ip.org> <20080709185837.GA27406@toroid.org> <20080709191125.GK3946@alvh.no-ip.org> <20080710031140.GA427@toroid.org> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.89 tagged_above=0 required=5 tests=AWL=0.890 X-Spam-Level: X-Archive-Number: 200807/581 X-Sequence-Number: 120841 ------=_Part_18308_20526414.1215795457922 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wed, Jul 9, 2008 at 10:11 PM, Abhijit Menon-Sen wrote: > At 2008-07-09 15:11:25 -0400, alvherre@commandprompt.com wrote: >> >> No, actually I meant having a lone "list =3D lappend(list, newseq);" in >> the loop, so that ExecGrantStmt_oids is called only once. > > Yes, I understand what you meant. I just phrased my agreement poorly. > Here's a more precise phrasing. ;-) > > (I agree with Robert Treat that there seems to be no point granting > SELECT on the sequence. I don't *particularly* care about it, but I > tend towards wanting to drop that bit. This patch reflects that.) > Hi, sorry for the delay i was busy... attached is a new version of the patch, it implements Alvaro's suggestion and fix a bug i found (it wasn't managing GRANT ALL) :( About the SELECT issue, AFAIU Robert doesn't complaint he just asked what is the use case... if people think it should be removed ok, but OTOH: why? i don't think that affects anything... --=20 regards, Jaime Casanova Soporte y capacitaci=F3n de PostgreSQL Guayaquil - Ecuador Cel. (593) 87171157 ------=_Part_18308_20526414.1215795457922 Content-Type: text/x-diff; name=grant_seq-v2.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fij17dj10 Content-Disposition: attachment; filename=grant_seq-v2.patch SW5kZXg6IGRvYy9zcmMvc2dtbC9yZWYvZ3JhbnQuc2dtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv aG9tZS9wb3N0Z3Jlcy9jdnNob21lL3Bnc3FsL2RvYy9zcmMvc2dtbC9yZWYvZ3JhbnQuc2dtbCx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS43MApkaWZmIC1jIC1yMS43MCBncmFudC5zZ21sCioqKiBk b2Mvc3JjL3NnbWwvcmVmL2dyYW50LnNnbWwJMyBKdWwgMjAwOCAxNTo1OTo1NSAtMDAwMAkxLjcw Ci0tLSBkb2Mvc3JjL3NnbWwvcmVmL2dyYW50LnNnbWwJMTEgSnVsIDIwMDggMTY6Mjk6NTIgLTAw MDAKKioqKioqKioqKioqKioqCioqKiA0MDEsNDEwICoqKioKICAgICA8L3BhcmE+CiAgCiAgICAg PHBhcmE+CiEgICAgIEdyYW50aW5nIHBlcm1pc3Npb24gb24gYSB0YWJsZSBkb2VzIG5vdCBhdXRv bWF0aWNhbGx5IGV4dGVuZCAKISAgICAgcGVybWlzc2lvbnMgdG8gYW55IHNlcXVlbmNlcyB1c2Vk IGJ5IHRoZSB0YWJsZSwgaW5jbHVkaW5nIAohICAgICBzZXF1ZW5jZXMgdGllZCB0byA8dHlwZT5T RVJJQUw8Lz4gY29sdW1ucy4gIFBlcm1pc3Npb25zIG9uIAohICAgICBzZXF1ZW5jZSBtdXN0IGJl IHNldCBzZXBhcmF0ZWx5LgogICAgIDwvcGFyYT4KICAKICAgICA8cGFyYT4KLS0tIDQwMSw0MDkg LS0tLQogICAgIDwvcGFyYT4KICAKICAgICA8cGFyYT4KISAgICAgR3JhbnRpbmcgcGVybWlzc2lv biBvbiBhIHRhYmxlIGF1dG9tYXRpY2FsbHkgZXh0ZW5kIAohICAgICBwZXJtaXNzaW9ucyB0byBh bnkgc2VxdWVuY2VzIG93bmVkIGJ5IHRoZSB0YWJsZSwgaW5jbHVkaW5nIAohICAgICBzZXF1ZW5j ZXMgdGllZCB0byA8dHlwZT5TRVJJQUw8Lz4gY29sdW1ucy4KICAgICA8L3BhcmE+CiAgCiAgICAg PHBhcmE+CkluZGV4OiBzcmMvYmFja2VuZC9jYXRhbG9nL2FjbGNoay5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9ob21lL3Bvc3RncmVzL2N2c2hvbWUvcGdzcWwvc3JjL2JhY2tlbmQvY2F0YWxvZy9h Y2xjaGsuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDcKZGlmZiAtYyAtcjEuMTQ3IGFjbGNo ay5jCioqKiBzcmMvYmFja2VuZC9jYXRhbG9nL2FjbGNoay5jCTE5IEp1biAyMDA4IDAwOjQ2OjAz IC0wMDAwCTEuMTQ3Ci0tLSBzcmMvYmFja2VuZC9jYXRhbG9nL2FjbGNoay5jCTExIEp1bCAyMDA4 IDE2OjM3OjI0IC0wMDAwCioqKioqKioqKioqKioqKgoqKiogMzYxLDM2NiAqKioqCi0tLSAzNjEs NDA2IC0tLS0KICAJfQogIAogIAlFeGVjR3JhbnRTdG10X29pZHMoJmlzdG10KTsKKyAKKyAJLyoK KyAJICogSWYgdGhlIG9ianR5cGUgaXMgYSByZWxhdGlvbiBhbmQgdGhlIHByaXZpbGVnZXMgaW5j bHVkZXMgSU5TRVJULCBVUERBVEUgCisgCSAqIG9yIFNFTEVDVCB0aGVuIGV4dGVuZHMgdGhlIEdS QU5UL1JFVk9LRSB0byB0aGUgc2VxdWVuY2VzIG93bmVkIGJ5IHRoZSAKKyAJICogcmVsYXRpb24K KyAJICovCisgCWlmICgoaXN0bXQub2JqdHlwZSA9PSBBQ0xfT0JKRUNUX1JFTEFUSU9OKSAmJiAo aXN0bXQuYWxsX3ByaXZzIHx8ICAKKyAJCShpc3RtdC5wcml2aWxlZ2VzICYgKEFDTF9JTlNFUlQg fCBBQ0xfVVBEQVRFIHwgQUNMX1NFTEVDVCkpKSkgCisgCXsKKyAJCUludGVybmFsR3JhbnQgaXN0 bXRfc2VxOworIAorIAkJaXN0bXRfc2VxLmlzX2dyYW50ID0gaXN0bXQuaXNfZ3JhbnQ7CisgCQlp c3RtdF9zZXEub2JqdHlwZSA9IEFDTF9PQkpFQ1RfU0VRVUVOQ0U7CisgCQlpc3RtdF9zZXEuZ3Jh bnRlZXMgPSBpc3RtdC5ncmFudGVlczsKKyAJCWlzdG10X3NlcS5ncmFudF9vcHRpb24gPSBpc3Rt dC5ncmFudF9vcHRpb247CisgCQlpc3RtdF9zZXEuYmVoYXZpb3IgPSBpc3RtdC5iZWhhdmlvcjsK KyAKKyAJCWlzdG10X3NlcS5hbGxfcHJpdnMgPSBmYWxzZTsKKyAJCWlzdG10X3NlcS5wcml2aWxl Z2VzID0gQUNMX05PX1JJR0hUUzsKKyAKKyAJCWlmIChpc3RtdC5hbGxfcHJpdnMpCisgCQkJaXN0 bXRfc2VxLmFsbF9wcml2cyA9IHRydWU7CisgCQllbHNlCisgCQl7CisgCQkJaWYgKGlzdG10LnBy aXZpbGVnZXMgJiAoQUNMX0lOU0VSVCkpIAorIAkJCQlpc3RtdF9zZXEucHJpdmlsZWdlcyB8PSBB Q0xfVVNBR0U7CisgCQkJaWYgKGlzdG10LnByaXZpbGVnZXMgJiAoQUNMX1VQREFURSkpIAorIAkJ CQlpc3RtdF9zZXEucHJpdmlsZWdlcyB8PSBBQ0xfVVBEQVRFOworIAkJCWlmIChpc3RtdC5wcml2 aWxlZ2VzICYgKEFDTF9TRUxFQ1QpKSAKKyAJCQkJaXN0bXRfc2VxLnByaXZpbGVnZXMgfD0gQUNM X1NFTEVDVDsKKyAJCX0KKyAgCisgCQlpc3RtdF9zZXEub2JqZWN0cyA9IE5JTDsKKyAJCWZvcmVh Y2goY2VsbCwgaXN0bXQub2JqZWN0cykKKyAgICAgICAgIAlpc3RtdF9zZXEub2JqZWN0cyA9IGxp c3RfY29uY2F0KGlzdG10X3NlcS5vYmplY3RzLAorIAkJCQkJCQkJZ2V0T3duZWRTZXF1ZW5jZXMo bGZpcnN0X29pZChjZWxsKSkpOworICAKKyAJCWlmIChpc3RtdF9zZXEub2JqZWN0cyAhPSBOSUwp CisgCQkJRXhlY0dyYW50U3RtdF9vaWRzKCZpc3RtdF9zZXEpOworIAl9IAogIH0KICAKICAvKgpJ bmRleDogc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9kZXBlbmRlbmN5Lm91dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 ClJDUyBmaWxlOiAvaG9tZS9wb3N0Z3Jlcy9jdnNob21lL3Bnc3FsL3NyYy90ZXN0L3JlZ3Jlc3Mv ZXhwZWN0ZWQvZGVwZW5kZW5jeS5vdXQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNwpkaWZmIC1j IC1yMS43IGRlcGVuZGVuY3kub3V0CioqKiBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2RlcGVu ZGVuY3kub3V0CTMgSnVsIDIwMDggMTU6NTk6NTUgLTAwMDAJMS43Ci0tLSBzcmMvdGVzdC9yZWdy ZXNzL2V4cGVjdGVkL2RlcGVuZGVuY3kub3V0CTExIEp1bCAyMDA4IDE2OjUzOjE0IC0wMDAwCioq KioqKioqKioqKioqKgoqKiogMTMsMjIgKioqKgogIC0tIGNhbid0IGRyb3AgbmVpdGhlciBiZWNh dXNlIHRoZXkgaGF2ZSBwcml2aWxlZ2VzIHNvbWV3aGVyZQogIERST1AgVVNFUiByZWdyZXNzaW9u X3VzZXI7CiAgRVJST1I6ICByb2xlICJyZWdyZXNzaW9uX3VzZXIiIGNhbm5vdCBiZSBkcm9wcGVk IGJlY2F1c2Ugc29tZSBvYmplY3RzIGRlcGVuZCBvbiBpdAohIERFVEFJTDogIGFjY2VzcyB0byB0 YWJsZSBkZXB0ZXN0CiAgRFJPUCBHUk9VUCByZWdyZXNzaW9uX2dyb3VwOwogIEVSUk9SOiAgcm9s ZSAicmVncmVzc2lvbl9ncm91cCIgY2Fubm90IGJlIGRyb3BwZWQgYmVjYXVzZSBzb21lIG9iamVj dHMgZGVwZW5kIG9uIGl0CiEgREVUQUlMOiAgYWNjZXNzIHRvIHRhYmxlIGRlcHRlc3QKICAtLSBp ZiB3ZSByZXZva2UgdGhlIHByaXZpbGVnZXMgd2UgY2FuIGRyb3AgdGhlIGdyb3VwCiAgUkVWT0tF IFNFTEVDVCBPTiBkZXB0ZXN0IEZST00gR1JPVVAgcmVncmVzc2lvbl9ncm91cDsKICBEUk9QIEdS T1VQIHJlZ3Jlc3Npb25fZ3JvdXA7Ci0tLSAxMywyNCAtLS0tCiAgLS0gY2FuJ3QgZHJvcCBuZWl0 aGVyIGJlY2F1c2UgdGhleSBoYXZlIHByaXZpbGVnZXMgc29tZXdoZXJlCiAgRFJPUCBVU0VSIHJl Z3Jlc3Npb25fdXNlcjsKICBFUlJPUjogIHJvbGUgInJlZ3Jlc3Npb25fdXNlciIgY2Fubm90IGJl IGRyb3BwZWQgYmVjYXVzZSBzb21lIG9iamVjdHMgZGVwZW5kIG9uIGl0CiEgREVUQUlMOiAgYWNj ZXNzIHRvIHNlcXVlbmNlIGRlcHRlc3RfZjFfc2VxCiEgYWNjZXNzIHRvIHRhYmxlIGRlcHRlc3QK ICBEUk9QIEdST1VQIHJlZ3Jlc3Npb25fZ3JvdXA7CiAgRVJST1I6ICByb2xlICJyZWdyZXNzaW9u X2dyb3VwIiBjYW5ub3QgYmUgZHJvcHBlZCBiZWNhdXNlIHNvbWUgb2JqZWN0cyBkZXBlbmQgb24g aXQKISBERVRBSUw6ICBhY2Nlc3MgdG8gc2VxdWVuY2UgZGVwdGVzdF9mMV9zZXEKISBhY2Nlc3Mg dG8gdGFibGUgZGVwdGVzdAogIC0tIGlmIHdlIHJldm9rZSB0aGUgcHJpdmlsZWdlcyB3ZSBjYW4g ZHJvcCB0aGUgZ3JvdXAKICBSRVZPS0UgU0VMRUNUIE9OIGRlcHRlc3QgRlJPTSBHUk9VUCByZWdy ZXNzaW9uX2dyb3VwOwogIERST1AgR1JPVVAgcmVncmVzc2lvbl9ncm91cDsK ------=_Part_18308_20526414.1215795457922--