Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 72BB7650B2B for ; Sat, 12 Jul 2008 16:39:20 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 21029-06 for ; Sat, 12 Jul 2008 16:39:12 -0300 (ADT) X-Greylist: delayed 00:07:02.936413 by SQLgrey-1.7.6 Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.29]) by postgresql.org (Postfix) with ESMTP id 06BE7650B1B for ; Sat, 12 Jul 2008 16:39:14 -0300 (ADT) Received: by yw-out-2324.google.com with SMTP id 3so1955630ywj.73 for ; Sat, 12 Jul 2008 12:39:11 -0700 (PDT) Received: by 10.151.82.13 with SMTP id j13mr6981204ybl.38.1215891123116; Sat, 12 Jul 2008 12:32:03 -0700 (PDT) Received: by 10.150.151.5 with HTTP; Sat, 12 Jul 2008 12:32:03 -0700 (PDT) Message-ID: <3073cc9b0807121232m6b8e6ae0ycaa78d6b8595d39d@mail.gmail.com> Date: Sat, 12 Jul 2008 14:32:03 -0500 From: "Jaime Casanova" To: "Abhijit Menon-Sen" Subject: Re: Extending grant insert on tables to sequences Cc: "Alvaro Herrera" , "Jaime Casanova" , pgsql-hackers@postgresql.org In-Reply-To: <20080712113041.GA25112@toroid.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_44707_22575799.1215891123079" References: <20080708133244.GB4095@alvh.no-ip.org> <20080709185837.GA27406@toroid.org> <20080709191125.GK3946@alvh.no-ip.org> <20080710031140.GA427@toroid.org> <3073cc9b0807110957w71869487p17fb58cb98abc520@mail.gmail.com> <20080712113041.GA25112@toroid.org> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200807/622 X-Sequence-Number: 120882 ------=_Part_44707_22575799.1215891123079 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sat, Jul 12, 2008 at 6:30 AM, Abhijit Menon-Sen wrote: > >> >> ! Granting permission on a table automatically extend >> ! permissions to any sequences owned by the table, including >> ! sequences tied to SERIAL columns. >> > > Should be "Granting permissions on a table automatically extends those > permissions to...". > what about "extends them to..." >> + if ((istmt.objtype =3D=3D ACL_OBJECT_RELATION) && (istmt.all_privs= || >> + (istmt.privileges & (ACL_INSERT | ACL_UPDATE | ACL_SELECT)= ))) >> + { > > The parentheses around the first comparison can go away, and also the > ones around the ACL_* here: > ok --=20 regards, Jaime Casanova Soporte y capacitaci=F3n de PostgreSQL Guayaquil - Ecuador Cel. (593) 87171157 ------=_Part_44707_22575799.1215891123079 Content-Type: text/x-diff; name=grant_seq-v3.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fikm5kpw0 Content-Disposition: attachment; filename=grant_seq-v3.patch SW5kZXg6IGRvYy9zcmMvc2dtbC9yZWYvZ3JhbnQuc2dtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv aG9tZS9wb3N0Z3Jlcy9jdnNob21lL3Bnc3FsL2RvYy9zcmMvc2dtbC9yZWYvZ3JhbnQuc2dtbCx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS43MApkaWZmIC1jIC1yMS43MCBncmFudC5zZ21sCioqKiBk b2Mvc3JjL3NnbWwvcmVmL2dyYW50LnNnbWwJMyBKdWwgMjAwOCAxNTo1OTo1NSAtMDAwMAkxLjcw Ci0tLSBkb2Mvc3JjL3NnbWwvcmVmL2dyYW50LnNnbWwJMTIgSnVsIDIwMDggMTk6MjI6MDEgLTAw MDAKKioqKioqKioqKioqKioqCioqKiA0MDEsNDEwICoqKioKICAgICA8L3BhcmE+CiAgCiAgICAg PHBhcmE+CiEgICAgIEdyYW50aW5nIHBlcm1pc3Npb24gb24gYSB0YWJsZSBkb2VzIG5vdCBhdXRv bWF0aWNhbGx5IGV4dGVuZCAKISAgICAgcGVybWlzc2lvbnMgdG8gYW55IHNlcXVlbmNlcyB1c2Vk IGJ5IHRoZSB0YWJsZSwgaW5jbHVkaW5nIAohICAgICBzZXF1ZW5jZXMgdGllZCB0byA8dHlwZT5T RVJJQUw8Lz4gY29sdW1ucy4gIFBlcm1pc3Npb25zIG9uIAohICAgICBzZXF1ZW5jZSBtdXN0IGJl IHNldCBzZXBhcmF0ZWx5LgogICAgIDwvcGFyYT4KICAKICAgICA8cGFyYT4KLS0tIDQwMSw0MDkg LS0tLQogICAgIDwvcGFyYT4KICAKICAgICA8cGFyYT4KISAgICAgR3JhbnRpbmcgcGVybWlzc2lv bnMgb24gYSB0YWJsZSBhdXRvbWF0aWNhbGx5IGV4dGVuZCAKISAgICAgdGhlbSB0byBhbnkgc2Vx dWVuY2VzIG93bmVkIGJ5IHRoZSB0YWJsZSwgaW5jbHVkaW5nIAohICAgICBzZXF1ZW5jZXMgdGll ZCB0byA8dHlwZT5TRVJJQUw8Lz4gY29sdW1ucy4KICAgICA8L3BhcmE+CiAgCiAgICAgPHBhcmE+ CkluZGV4OiBzcmMvYmFja2VuZC9jYXRhbG9nL2FjbGNoay5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9ob21lL3Bvc3RncmVzL2N2c2hvbWUvcGdzcWwvc3JjL2JhY2tlbmQvY2F0YWxvZy9hY2xjaGsu Yyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDcKZGlmZiAtYyAtcjEuMTQ3IGFjbGNoay5jCioq KiBzcmMvYmFja2VuZC9jYXRhbG9nL2FjbGNoay5jCTE5IEp1biAyMDA4IDAwOjQ2OjAzIC0wMDAw CTEuMTQ3Ci0tLSBzcmMvYmFja2VuZC9jYXRhbG9nL2FjbGNoay5jCTEyIEp1bCAyMDA4IDE4OjM5 OjQwIC0wMDAwCioqKioqKioqKioqKioqKgoqKiogMzYxLDM2NiAqKioqCi0tLSAzNjEsNDA2IC0t LS0KICAJfQogIAogIAlFeGVjR3JhbnRTdG10X29pZHMoJmlzdG10KTsKKyAKKyAJLyoKKyAJICog SWYgdGhlIG9ianR5cGUgaXMgYSByZWxhdGlvbiBhbmQgdGhlIHByaXZpbGVnZXMgaW5jbHVkZXMg SU5TRVJULCBVUERBVEUgCisgCSAqIG9yIFNFTEVDVCB0aGVuIGV4dGVuZHMgdGhlIEdSQU5UL1JF Vk9LRSB0byB0aGUgc2VxdWVuY2VzIG93bmVkIGJ5IHRoZSAKKyAJICogcmVsYXRpb24KKyAJICov CisgCWlmIChpc3RtdC5vYmp0eXBlID09IEFDTF9PQkpFQ1RfUkVMQVRJT04gJiYgKGlzdG10LmFs bF9wcml2cyB8fCAgCisgCQkoaXN0bXQucHJpdmlsZWdlcyAmIChBQ0xfSU5TRVJUIHwgQUNMX1VQ REFURSB8IEFDTF9TRUxFQ1QpKSkpIAorIAl7CisgCQlJbnRlcm5hbEdyYW50IGlzdG10X3NlcTsK KyAKKyAJCWlzdG10X3NlcS5pc19ncmFudCA9IGlzdG10LmlzX2dyYW50OworIAkJaXN0bXRfc2Vx Lm9ianR5cGUgPSBBQ0xfT0JKRUNUX1NFUVVFTkNFOworIAkJaXN0bXRfc2VxLmdyYW50ZWVzID0g aXN0bXQuZ3JhbnRlZXM7CisgCQlpc3RtdF9zZXEuZ3JhbnRfb3B0aW9uID0gaXN0bXQuZ3JhbnRf b3B0aW9uOworIAkJaXN0bXRfc2VxLmJlaGF2aW9yID0gaXN0bXQuYmVoYXZpb3I7CisgCisgCQlp c3RtdF9zZXEuYWxsX3ByaXZzID0gZmFsc2U7CisgCQlpc3RtdF9zZXEucHJpdmlsZWdlcyA9IEFD TF9OT19SSUdIVFM7CisgCisgCQlpZiAoaXN0bXQuYWxsX3ByaXZzKQorIAkJCWlzdG10X3NlcS5h bGxfcHJpdnMgPSB0cnVlOworIAkJZWxzZQorIAkJeworIAkJCWlmIChpc3RtdC5wcml2aWxlZ2Vz ICYgQUNMX0lOU0VSVCkgCisgCQkJCWlzdG10X3NlcS5wcml2aWxlZ2VzIHw9IEFDTF9VU0FHRTsK KyAJCQlpZiAoaXN0bXQucHJpdmlsZWdlcyAmIEFDTF9VUERBVEUpIAorIAkJCQlpc3RtdF9zZXEu cHJpdmlsZWdlcyB8PSBBQ0xfVVBEQVRFOworIAkJCWlmIChpc3RtdC5wcml2aWxlZ2VzICYgQUNM X1NFTEVDVCkgCisgCQkJCWlzdG10X3NlcS5wcml2aWxlZ2VzIHw9IEFDTF9TRUxFQ1Q7CisgCQl9 CisgIAorIAkJaXN0bXRfc2VxLm9iamVjdHMgPSBOSUw7CisgCQlmb3JlYWNoKGNlbGwsIGlzdG10 Lm9iamVjdHMpCisgICAgICAgICAJaXN0bXRfc2VxLm9iamVjdHMgPSBsaXN0X2NvbmNhdChpc3Rt dF9zZXEub2JqZWN0cywKKyAJCQkJCQkJCWdldE93bmVkU2VxdWVuY2VzKGxmaXJzdF9vaWQoY2Vs bCkpKTsKKyAgCisgCQlpZiAoaXN0bXRfc2VxLm9iamVjdHMgIT0gTklMKQorIAkJCUV4ZWNHcmFu dFN0bXRfb2lkcygmaXN0bXRfc2VxKTsKKyAJfSAKICB9CiAgCiAgLyoKSW5kZXg6IHNyYy90ZXN0 L3JlZ3Jlc3MvZXhwZWN0ZWQvZGVwZW5kZW5jeS5vdXQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hv bWUvcG9zdGdyZXMvY3ZzaG9tZS9wZ3NxbC9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2RlcGVu ZGVuY3kub3V0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjcKZGlmZiAtYyAtcjEuNyBkZXBlbmRl bmN5Lm91dAoqKiogc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9kZXBlbmRlbmN5Lm91dAkzIEp1 bCAyMDA4IDE1OjU5OjU1IC0wMDAwCTEuNwotLS0gc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9k ZXBlbmRlbmN5Lm91dAkxMSBKdWwgMjAwOCAxNjo1MzoxNCAtMDAwMAoqKioqKioqKioqKioqKioK KioqIDEzLDIyICoqKioKICAtLSBjYW4ndCBkcm9wIG5laXRoZXIgYmVjYXVzZSB0aGV5IGhhdmUg cHJpdmlsZWdlcyBzb21ld2hlcmUKICBEUk9QIFVTRVIgcmVncmVzc2lvbl91c2VyOwogIEVSUk9S OiAgcm9sZSAicmVncmVzc2lvbl91c2VyIiBjYW5ub3QgYmUgZHJvcHBlZCBiZWNhdXNlIHNvbWUg b2JqZWN0cyBkZXBlbmQgb24gaXQKISBERVRBSUw6ICBhY2Nlc3MgdG8gdGFibGUgZGVwdGVzdAog IERST1AgR1JPVVAgcmVncmVzc2lvbl9ncm91cDsKICBFUlJPUjogIHJvbGUgInJlZ3Jlc3Npb25f Z3JvdXAiIGNhbm5vdCBiZSBkcm9wcGVkIGJlY2F1c2Ugc29tZSBvYmplY3RzIGRlcGVuZCBvbiBp dAohIERFVEFJTDogIGFjY2VzcyB0byB0YWJsZSBkZXB0ZXN0CiAgLS0gaWYgd2UgcmV2b2tlIHRo ZSBwcml2aWxlZ2VzIHdlIGNhbiBkcm9wIHRoZSBncm91cAogIFJFVk9LRSBTRUxFQ1QgT04gZGVw dGVzdCBGUk9NIEdST1VQIHJlZ3Jlc3Npb25fZ3JvdXA7CiAgRFJPUCBHUk9VUCByZWdyZXNzaW9u X2dyb3VwOwotLS0gMTMsMjQgLS0tLQogIC0tIGNhbid0IGRyb3AgbmVpdGhlciBiZWNhdXNlIHRo ZXkgaGF2ZSBwcml2aWxlZ2VzIHNvbWV3aGVyZQogIERST1AgVVNFUiByZWdyZXNzaW9uX3VzZXI7 CiAgRVJST1I6ICByb2xlICJyZWdyZXNzaW9uX3VzZXIiIGNhbm5vdCBiZSBkcm9wcGVkIGJlY2F1 c2Ugc29tZSBvYmplY3RzIGRlcGVuZCBvbiBpdAohIERFVEFJTDogIGFjY2VzcyB0byBzZXF1ZW5j ZSBkZXB0ZXN0X2YxX3NlcQohIGFjY2VzcyB0byB0YWJsZSBkZXB0ZXN0CiAgRFJPUCBHUk9VUCBy ZWdyZXNzaW9uX2dyb3VwOwogIEVSUk9SOiAgcm9sZSAicmVncmVzc2lvbl9ncm91cCIgY2Fubm90 IGJlIGRyb3BwZWQgYmVjYXVzZSBzb21lIG9iamVjdHMgZGVwZW5kIG9uIGl0CiEgREVUQUlMOiAg YWNjZXNzIHRvIHNlcXVlbmNlIGRlcHRlc3RfZjFfc2VxCiEgYWNjZXNzIHRvIHRhYmxlIGRlcHRl c3QKICAtLSBpZiB3ZSByZXZva2UgdGhlIHByaXZpbGVnZXMgd2UgY2FuIGRyb3AgdGhlIGdyb3Vw CiAgUkVWT0tFIFNFTEVDVCBPTiBkZXB0ZXN0IEZST00gR1JPVVAgcmVncmVzc2lvbl9ncm91cDsK ICBEUk9QIEdST1VQIHJlZ3Jlc3Npb25fZ3JvdXA7Cg== ------=_Part_44707_22575799.1215891123079--