Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 0D627650004 for ; Sat, 6 Sep 2008 17:41:38 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 00250-05 for ; Sat, 6 Sep 2008 17:41:31 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by postgresql.org (Postfix) with ESMTP id 5E15264FF82 for ; Sat, 6 Sep 2008 17:41:30 -0300 (ADT) Received: by rv-out-0506.google.com with SMTP id b25so1276707rvf.43 for ; Sat, 06 Sep 2008 13:41:29 -0700 (PDT) Received: by 10.140.247.11 with SMTP id u11mr7701434rvh.37.1220733689638; Sat, 06 Sep 2008 13:41:29 -0700 (PDT) Received: by 10.141.51.11 with HTTP; Sat, 6 Sep 2008 13:41:29 -0700 (PDT) Message-ID: <3073cc9b0809061341q5c747488i85491e4c8e2420ba@mail.gmail.com> Date: Sat, 6 Sep 2008 15:41:29 -0500 From: "Jaime Casanova" To: "Ryan Bradetich" Subject: Re: [PgFoundry] Unsigned Data Types [1 of 2] Cc: pgsql-patches In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_55414_6595871.1220733689630" References: X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/71 X-Sequence-Number: 7086 ------=_Part_55414_6595871.1220733689630 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sun, Aug 31, 2008 at 3:35 PM, Ryan Bradetich wrot= e: > Hello all, > a few comments. - i think you have to add some more comments in uint.c file and maybe a header indicating this is part of the postgresql project or that is intended to use with postgres or something of the like - what is uint1? i know int, int2, int4, int8 so i think we should have uint, uint2, uint4 (maybe uint8?) > uint-base.tar.bz2 -- The core of the unsigned integer type. seems there is something wrong in the unlikely macro (i'm using GCC 4.2.3 in Ubuntu 4.2.3-2ubuntu7 with amd64) postgres=3D# select -256::uint1; ERROR: uint1 out of range STATEMENT: select -256::uint1; ERROR: uint1 out of range postgres=3D# select -255::uint1; ?column? ---------- -255 (1 row) postgres=3D# select -2::uint1; ?column? ---------- -2 (1 row) postgres=3D# select -5::uint1 + 30::uint1; ?column? ---------- 25 (1 row) > uint-tests.tar.bz2 -- The regression tests. > here failed two regression tests but that is because the path > * Converted build system to use PGXS (more portable). the Makefile doesn't work here... i have installed postgres 8.3.3 from ubuntu package and the test env i compile manually (the uint module tried to install in the ubuntu location while it should in the env location) attached a Makefile that fix that i still have to make some more test... --=20 regards, Jaime Casanova Soporte y capacitaci=F3n de PostgreSQL Asesor=EDa y desarrollo de sistemas Guayaquil - Ecuador Cel. (593) 87171157 ------=_Part_55414_6595871.1220733689630 Content-Type: application/octet-stream; name=Makefile Content-Transfer-Encoding: base64 X-Attachment-Id: f_fksoo2dv1 Content-Disposition: attachment; filename=Makefile TU9EVUxFUyA9IHVpbnQKREFUQV9idWlsdCA9IHVpbnQuc3FsIHNxbC9jb3B5LnNxbCBzcWwvaW5k ZXhlcy5zcWwKREFUQSA9IHVuaW5zdGFsbF91aW50LnNxbApSRUdSRVNTID0gaW5pdCBjYXN0IGNv bXBhcmlzaW9uX29wcyBiaXRfb3BzIHRhYmxlcyBpbnNlcnQgY29weSBpbmRleGVzCkVYVFJBX0NM RUFOID0gZGF0YS9jb3B5X2JpbmFyeS5kYXRhCgppZmRlZiBVU0VfUEdYUwpQR19DT05GSUcgPSBw Z19jb25maWcKUEdYUyA6PSAkKHNoZWxsICQoUEdfQ09ORklHKSAtLXBneHMpCmluY2x1ZGUgJChQ R1hTKQplbHNlCnN1YmRpciA9IGNvbnRyaWIvdWludAp0b3BfYnVpbGRkaXIgPSAuLi8uLgppbmNs dWRlICQodG9wX2J1aWxkZGlyKS9zcmMvTWFrZWZpbGUuZ2xvYmFsCmluY2x1ZGUgJCh0b3Bfc3Jj ZGlyKS9jb250cmliL2NvbnRyaWItZ2xvYmFsLm1rCmVuZGlmCgpQV0Q9JChzaGVsbCBwd2QpCgpz cWwvY29weS5zcWw6IHNxbC9jb3B5LnNxbC5pbgoJc2VkICdzLEBhYnNfYnVpbGRkaXJALCQoUFdE KSxnJyBzcWwvY29weS5zcWwuaW4gPiBzcWwvY29weS5zcWwKCnNxbC9pbmRleGVzLnNxbDogc3Fs L2luZGV4ZXMuc3FsLmluCglzZWQgJ3MsQGFic19idWlsZGRpckAsJChQV0QpLGcnIHNxbC9pbmRl eGVzLnNxbC5pbiA+IHNxbC9pbmRleGVzLnNxbAo= ------=_Part_55414_6595871.1220733689630 Content-Type: application/octet-stream; name=regression.diffs Content-Transfer-Encoding: base64 X-Attachment-Id: f_fksp87kw2 Content-Disposition: attachment; filename=regression.diffs KioqIC4vZXhwZWN0ZWQvY29weS5vdXQJU2F0IFNlcCAgNiAxNTowMDoxMSAyMDA4Ci0tLSAuL3Jl c3VsdHMvY29weS5vdXQJU2F0IFNlcCAgNiAxNTozODo0OCAyMDA4CioqKioqKioqKioqKioqKgoq KiogNSwxMSAqKioqCiAgICAgY29sMyB1aW50MSBOT1QgTlVMTAogICkgV0lUSE9VVCBPSURTOwog IC0tIExvYWQgY29weSAodGV4dCkgZGF0YS4KISBDT1BZIHVpbnRfY29weV90ZXN0IEZST00gJy9o b21lL3JicmFkL3NyYy91aW50L2RhdGEvY29weV90ZXh0LmRhdGEnOwogIC0tIFZlcmlmeSBjb3B5 ICh0ZXh0KSBkYXRhLgogIFNFTEVDVCBjb2wzLCBjb2wyLCBjb2wxCiAgRlJPTSAgIHVpbnRfY29w eV90ZXN0Ci0tLSA1LDExIC0tLS0KICAgICBjb2wzIHVpbnQxIE5PVCBOVUxMCiAgKSBXSVRIT1VU IE9JRFM7CiAgLS0gTG9hZCBjb3B5ICh0ZXh0KSBkYXRhLgohIENPUFkgdWludF9jb3B5X3Rlc3Qg RlJPTSAnL3Zhci9saWIvcG9zdGdyZXNxbC9QR1JFTEVBU0VTL3Bnc3FsL2NvbnRyaWIvdWludC9k YXRhL2NvcHlfdGV4dC5kYXRhJzsKICAtLSBWZXJpZnkgY29weSAodGV4dCkgZGF0YS4KICBTRUxF Q1QgY29sMywgY29sMiwgY29sMSAKICBGUk9NICAgdWludF9jb3B5X3Rlc3QKKioqKioqKioqKioq KioqCioqKiAzOSw0OSAqKioqCiAgKDI0IHJvd3MpCiAgCiAgLS0gU2F2ZSB0aGUgY29weSBkYXRh IHRvIGJpbmFyeS4KISBDT1BZIHVpbnRfY29weV90ZXN0IFRPICcvaG9tZS9yYnJhZC9zcmMvdWlu dC9kYXRhL2NvcHlfYmluYXJ5LmRhdGEnIFdJVEggQklOQVJZOwogIC0tIFJlbW92ZSByb3dzLgog IFRSVU5DQVRFIHVpbnRfY29weV90ZXN0OwogIC0tIExvYWQgY29weSAoYmluYXJ5KSBkYXRhLgoh IENPUFkgdWludF9jb3B5X3Rlc3QgRlJPTSAnL2hvbWUvcmJyYWQvc3JjL3VpbnQvZGF0YS9jb3B5 X2JpbmFyeS5kYXRhJyBXSVRIIEJJTkFSWTsKICAtLSBWZXJpZnkgY29weSAoYmluYXJ5KSBkYXRh LgogIFNFTEVDVCBjb2wzLCBjb2wyLCBjb2wxIAogIEZST00gICB1aW50X2NvcHlfdGVzdAotLS0g MzksNDkgLS0tLQogICgyNCByb3dzKQogIAogIC0tIFNhdmUgdGhlIGNvcHkgZGF0YSB0byBiaW5h cnkuCiEgQ09QWSB1aW50X2NvcHlfdGVzdCBUTyAnL3Zhci9saWIvcG9zdGdyZXNxbC9QR1JFTEVB U0VTL3Bnc3FsL2NvbnRyaWIvdWludC9kYXRhL2NvcHlfYmluYXJ5LmRhdGEnIFdJVEggQklOQVJZ OwogIC0tIFJlbW92ZSByb3dzLgogIFRSVU5DQVRFIHVpbnRfY29weV90ZXN0OwogIC0tIExvYWQg Y29weSAoYmluYXJ5KSBkYXRhLgohIENPUFkgdWludF9jb3B5X3Rlc3QgRlJPTSAnL3Zhci9saWIv cG9zdGdyZXNxbC9QR1JFTEVBU0VTL3Bnc3FsL2NvbnRyaWIvdWludC9kYXRhL2NvcHlfYmluYXJ5 LmRhdGEnIFdJVEggQklOQVJZOwogIC0tIFZlcmlmeSBjb3B5IChiaW5hcnkpIGRhdGEuCiAgU0VM RUNUIGNvbDMsIGNvbDIsIGNvbDEgCiAgRlJPTSAgIHVpbnRfY29weV90ZXN0Cgo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09CgoqKiogLi9leHBlY3RlZC9pbmRleGVzLm91dAlTYXQgU2VwICA2IDE1OjAwOjExIDIwMDgK LS0tIC4vcmVzdWx0cy9pbmRleGVzLm91dAlTYXQgU2VwICA2IDE1OjM4OjQ4IDIwMDgKKioqKioq KioqKioqKioqCioqKiAxODcsMTkzICoqKioKICAtLQogIENSRUFURSBUQUJMRSBoYXNoX3VpbnQx X2hlYXAgKHNlcW5vIHVpbnQxIE5PVCBOVUxMLCByYW5kb20gdWludDEgTk9UIE5VTEwpOwogIENS RUFURSBJTkRFWCBoYXNoX3VpbnQxX2luZGV4IE9OIGhhc2hfdWludDFfaGVhcCBVU0lORyBoYXNo IChyYW5kb20gdWludDFfb3BzKTsKISBDT1BZIGhhc2hfdWludDFfaGVhcCBGUk9NICcvaG9tZS9y YnJhZC9zcmMvdWludC9kYXRhL3VpbnQxX2hhc2guZGF0YSc7CiAgU0VMRUNUICoKICBGUk9NICAg aGFzaF91aW50MV9oZWFwCiAgV0hFUkUgIGhhc2hfdWludDFfaGVhcC5yYW5kb20gPSAyMzY6OnVp bnQxOwotLS0gMTg3LDE5MyAtLS0tCiAgLS0KICBDUkVBVEUgVEFCTEUgaGFzaF91aW50MV9oZWFw IChzZXFubyB1aW50MSBOT1QgTlVMTCwgcmFuZG9tIHVpbnQxIE5PVCBOVUxMKTsKICBDUkVBVEUg SU5ERVggaGFzaF91aW50MV9pbmRleCBPTiBoYXNoX3VpbnQxX2hlYXAgVVNJTkcgaGFzaCAocmFu ZG9tIHVpbnQxX29wcyk7CiEgQ09QWSBoYXNoX3VpbnQxX2hlYXAgRlJPTSAnL3Zhci9saWIvcG9z dGdyZXNxbC9QR1JFTEVBU0VTL3Bnc3FsL2NvbnRyaWIvdWludC9kYXRhL3VpbnQxX2hhc2guZGF0 YSc7CiAgU0VMRUNUICoKICBGUk9NICAgaGFzaF91aW50MV9oZWFwCiAgV0hFUkUgIGhhc2hfdWlu dDFfaGVhcC5yYW5kb20gPSAyMzY6OnVpbnQxOwoqKioqKioqKioqKioqKioKKioqIDIxOCwyMjQg KioqKgogIAogIENSRUFURSBUQUJMRSBoYXNoX3VpbnQyX2hlYXAgKHNlcW5vIHVpbnQyIE5PVCBO VUxMLCByYW5kb20gdWludDIgTk9UIE5VTEwpOwogIENSRUFURSBJTkRFWCBoYXNoX3VpbnQyX2lu ZGV4IE9OIGhhc2hfdWludDJfaGVhcCBVU0lORyBoYXNoIChyYW5kb20gdWludDJfb3BzKTsKISBD T1BZIGhhc2hfdWludDJfaGVhcCBGUk9NICcvaG9tZS9yYnJhZC9zcmMvdWludC9kYXRhL3VpbnQy X2hhc2guZGF0YSc7CiAgU0VMRUNUICoKICBGUk9NICAgaGFzaF91aW50Ml9oZWFwCiAgV0hFUkUg IGhhc2hfdWludDJfaGVhcC5yYW5kb20gPSAyNTA1MDo6dWludDI7Ci0tLSAyMTgsMjI0IC0tLS0K ICAKICBDUkVBVEUgVEFCTEUgaGFzaF91aW50Ml9oZWFwIChzZXFubyB1aW50MiBOT1QgTlVMTCwg cmFuZG9tIHVpbnQyIE5PVCBOVUxMKTsKICBDUkVBVEUgSU5ERVggaGFzaF91aW50Ml9pbmRleCBP TiBoYXNoX3VpbnQyX2hlYXAgVVNJTkcgaGFzaCAocmFuZG9tIHVpbnQyX29wcyk7CiEgQ09QWSBo YXNoX3VpbnQyX2hlYXAgRlJPTSAnL3Zhci9saWIvcG9zdGdyZXNxbC9QR1JFTEVBU0VTL3Bnc3Fs L2NvbnRyaWIvdWludC9kYXRhL3VpbnQyX2hhc2guZGF0YSc7CiAgU0VMRUNUICoKICBGUk9NICAg aGFzaF91aW50Ml9oZWFwCiAgV0hFUkUgIGhhc2hfdWludDJfaGVhcC5yYW5kb20gPSAyNTA1MDo6 dWludDI7CioqKioqKioqKioqKioqKgoqKiogMjQ5LDI1NSAqKioqCiAgCiAgQ1JFQVRFIFRBQkxF IGhhc2hfdWludDRfaGVhcCAoc2Vxbm8gdWludDQgTk9UIE5VTEwsIHJhbmRvbSB1aW50NCBOT1Qg TlVMTCk7CiAgQ1JFQVRFIElOREVYIGhhc2hfdWludDRfaW5kZXggT04gaGFzaF91aW50NF9oZWFw IFVTSU5HIGhhc2ggKHJhbmRvbSB1aW50NF9vcHMpOwohIENPUFkgaGFzaF91aW50NF9oZWFwIEZS T00gJy9ob21lL3JicmFkL3NyYy91aW50L2RhdGEvdWludDRfaGFzaC5kYXRhJzsKICBTRUxFQ1Qg KgogIEZST00gICBoYXNoX3VpbnQ0X2hlYXAKICBXSEVSRSAgaGFzaF91aW50NF9oZWFwLnJhbmRv bSA9IDg5ODg4MDgxNDo6dWludDQ7Ci0tLSAyNDksMjU1IC0tLS0KICAKICBDUkVBVEUgVEFCTEUg aGFzaF91aW50NF9oZWFwIChzZXFubyB1aW50NCBOT1QgTlVMTCwgcmFuZG9tIHVpbnQ0IE5PVCBO VUxMKTsKICBDUkVBVEUgSU5ERVggaGFzaF91aW50NF9pbmRleCBPTiBoYXNoX3VpbnQ0X2hlYXAg VVNJTkcgaGFzaCAocmFuZG9tIHVpbnQ0X29wcyk7CiEgQ09QWSBoYXNoX3VpbnQ0X2hlYXAgRlJP TSAnL3Zhci9saWIvcG9zdGdyZXNxbC9QR1JFTEVBU0VTL3Bnc3FsL2NvbnRyaWIvdWludC9kYXRh L3VpbnQ0X2hhc2guZGF0YSc7CiAgU0VMRUNUICoKICBGUk9NICAgaGFzaF91aW50NF9oZWFwCiAg V0hFUkUgIGhhc2hfdWludDRfaGVhcC5yYW5kb20gPSA4OTg4ODA4MTQ6OnVpbnQ0OwoKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQoK ------=_Part_55414_6595871.1220733689630--