Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id BA3D86501B0 for ; Thu, 11 Sep 2008 15:13:31 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 39044-01-2 for ; Thu, 11 Sep 2008 15:13:25 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.187]) by postgresql.org (Postfix) with ESMTP id 0E6B864FCD6 for ; Thu, 11 Sep 2008 15:12:41 -0300 (ADT) Received: by ti-out-0910.google.com with SMTP id y8so299955tia.5 for ; Thu, 11 Sep 2008 11:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=UH9ap9g0eZVURkY18gWVXv/I0lQ1X44FwbbR8tfOggM=; b=aWzRKCawpeytOeo2BSc1qG9qsXkB46G4SLTwJYkERLeXuqn+UG9NaPqoq2lfdl9MUK Pwr1XRxeDSHaSywuF6B7wX5Sy9kjuU0XaTk4WLh1zIeSZviBV2UL0TVc6X2ob0mBYcSS SEgzDBPpm0YI0pCoZuMMB5yAo+5TrGx7vOeC4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=O+g/t4WvRWSyTfiQ7Wc2nJ6M4zZqfeAwDMakWQiSEtiZCf4Zk1hIN4hZ5SPgUgtJYc zRBfxm5Z8+QlARxducMyJRVDJIRxy4JOkcfFmEWWjhmQdLIMoKrDlVdV/NzGnG6WPw0C KXdtFswhgqY0cbbY/jpJYQi0cTYArN3nO7I/E= Received: by 10.110.47.17 with SMTP id u17mr869725tiu.7.1221156759168; Thu, 11 Sep 2008 11:12:39 -0700 (PDT) Received: by 10.110.10.2 with HTTP; Thu, 11 Sep 2008 11:12:39 -0700 (PDT) Message-ID: <37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com> Date: Fri, 12 Sep 2008 04:12:39 +1000 From: "Brendan Jurd" To: "Tom Lane" Subject: Re: [PATCHES] to_date() validation Cc: "Martijn van Oosterhout" , "Alex Hunsaker" , pgsql-hackers@postgresql.org In-Reply-To: <2723.1221154495@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <37ed240d0808291839t21e19956mdfbdc80aeb1b3c19@mail.gmail.com> <34d269d40809061258t46f90218r3152814dd18880ab@mail.gmail.com> <37ed240d0809080124y3403224fpe3c34ca90df798a3@mail.gmail.com> <20080909092919.GB29604@svana.org> <37ed240d0809090404w2490d375l60b0fc972f899cec@mail.gmail.com> <37ed240d0809090546v3024a465j33216e8157bc54ca@mail.gmail.com> <2723.1221154495@sss.pgh.pa.us> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/815 X-Sequence-Number: 123944 On Fri, Sep 12, 2008 at 3:34 AM, Tom Lane wrote: > Applied with minimal modifications. I changed a couple of error > messages that didn't seem to meet the style guidelines, Great, thanks Tom. And thanks again to Alex and Martijn for helping me refine the patch. > and I moved all > of the to_timestamp tests into horology.sql, rather than having > essentially duplicate tests in timestamp.sql and timestamptz.sql. > Nice. That will make maintaining/extending the tests easier in future. Cheers, BJ