X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id B4BBA11F6232 for ; Fri, 28 Apr 2006 01:26:09 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 27100-07 for ; Fri, 28 Apr 2006 01:25:53 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from floppy.pyrenet.fr (news.pyrenet.fr [194.116.145.2]) by postgresql.org (Postfix) with ESMTP id 2146211F6240 for ; Fri, 28 Apr 2006 01:25:51 -0300 (ADT) Received: by floppy.pyrenet.fr (Postfix, from userid 106) id 4CDD930F25; Fri, 28 Apr 2006 06:25:50 +0200 (MET DST) From: Kris Jurka X-Newsgroups: pgsql.patches Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64 Date: Thu, 27 Apr 2006 21:25:48 -0700 Organization: Hub.Org Networking Services Lines: 63 Message-ID: <4451994C.8020001@ejurka.com> References: <154BA792-BB51-4F85-86E3-0BBAEB732C33@omniti.com> <200604272231.k3RMVYM28488@candle.pha.pa.us> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000701060701060701030709" X-Complaints-To: usenet@news.hub.org To: Bruce Momjian User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.12) Gecko/20060324 Debian/1.7.12-1.1 X-Accept-Language: en In-Reply-To: <200604272231.k3RMVYM28488@candle.pha.pa.us> To: pgsql-patches@postgresql.org X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200604/244 X-Sequence-Number: 19516 This is a multi-part message in MIME format. --------------000701060701060701030709 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Bruce Momjian wrote: > Great, changes attached and applied. I removed the solaris_i386 and > solaris_x86_64.s files and made just one solaris_x86.s. I updated the > build system to use the new file, updated the macros, and added some > documentation on the approach. Thanks. > > Would you test current CVS to make sure it still works properly? Thanks. > The patch adds an extra else in src/template/solaris that means the assembly file is not properly picked up. Also the claim that Sun's cc understands C preprocessor doesn't hold true for me: /usr/local/SUNWspro/bin/cc -Xa -v -DSUNOS4_CC -g -c tas.s Assembler: tas.s "tas.s", line 9 : Illegal mnemonic "tas.s", line 9 : Syntax error "tas.s", line 9 : Illegal mnemonic "tas.s", line 9 : Illegal mnemonic This is with cc -V cc: Sun WorkShop 6 update 2 C 5.3 Patch 111680-09 2003/05/18 --------------000701060701060701030709 Content-Type: text/plain; name="solaris-pick-tas.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="solaris-pick-tas.patch" Index: src/template/solaris =================================================================== RCS file: /projects/cvsroot/pgsql/src/template/solaris,v retrieving revision 1.26 diff -c -r1.26 solaris *** src/template/solaris 27 Apr 2006 22:28:42 -0000 1.26 --- src/template/solaris 28 Apr 2006 04:20:02 -0000 *************** *** 4,10 **** if test "$enable_debug" != yes; then CFLAGS="$CFLAGS -O" # any optimization breaks debug fi ! else # Pick the right test-and-set (TAS) code for the Sun compiler. # We would like to use in-line assembler, but the compiler # requires *.il files to be on every compile line, making --- 4,10 ---- if test "$enable_debug" != yes; then CFLAGS="$CFLAGS -O" # any optimization breaks debug fi ! # Pick the right test-and-set (TAS) code for the Sun compiler. # We would like to use in-line assembler, but the compiler # requires *.il files to be on every compile line, making --------------000701060701060701030709--