X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id E687B9F9B76 for ; Thu, 4 May 2006 16:17:36 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 10960-07 for ; Thu, 4 May 2006 16:17:13 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey- Received: from svr4.postgresql.org (svr4.postgresql.org [66.98.251.159]) by postgresql.org (Postfix) with ESMTP id C67BC9FA7B6 for ; Thu, 4 May 2006 16:17:13 -0300 (ADT) Received: from nwkes-gis-mail-1.sun.com (unknown [192.18.42.249]) by svr4.postgresql.org (Postfix) with ESMTP id 45B7E5B6956 for ; Thu, 4 May 2006 19:16:58 +0000 (GMT) Received: from d1-sfbay-03.sun.com ([192.18.39.113]) by nwkes-gis-mail-1.sun.com (8.12.9/8.12.9) with ESMTP id k44JGt6O028715 for ; Thu, 4 May 2006 12:16:56 -0700 (PDT) Received: from conversion-daemon.d1-sfbay-03.sun.com by d1-sfbay-03.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0IYR009019CSHF00@d1-sfbay-03.sun.com> (original mail from Robert.Lor@Sun.COM) for pgsql-patches@postgresql.org; Thu, 04 May 2006 12:16:55 -0700 (PDT) Received: from [129.149.6.38] by d1-sfbay-03.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0IYR00NM29K65110@d1-sfbay-03.sun.com>; Thu, 04 May 2006 12:16:55 -0700 (PDT) Date: Thu, 04 May 2006 12:17:56 -0700 From: Robert Lor Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64 In-reply-to: <200604300016.k3U0GGu13388@candle.pha.pa.us> To: Bruce Momjian Cc: Tom Lane , Theo Schlossnagle , Josh.Berkus@Sun.COM, PostgreSQL-patches Reply-To: Robert.Lor@Sun.COM Message-id: <445A5364.4090307@Sun.COM> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en References: <200604300016.k3U0GGu13388@candle.pha.pa.us> User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.7) Gecko/20050530 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200605/48 X-Sequence-Number: 19594 Hi Bruce, The new SPARC assembly file src/backend/port/tas/solaris_sparc.s uses / instead of ! for comments, and as a result the compile fails with Sun Studio 11. Please modify the first 3 lines to look like the following. > !======================================================================= > ! solaris_sparc.s -- compare and swap for solaris_sparc > !======================================================================= Thanks! -Robert Bruce Momjian wrote On 04/29/06 17:16,: >Tom Lane wrote: > > >>Theo Schlossnagle writes: >> >> >>>I'd remind everyone that the spinlock stuff is entirely optional at >>>build time. >>> >>> >>Not really. The performance hit for not having hardware spinlocks is >>so severe that it's not considered a reasonable fallback. >> >> >> >>>I also think it immensely useful to replace all of the tas subsystem >>>with cas so that one could reliabily lock these atomics with the process >>>id of the locker. >>> >>> >>I cannot, ever once in my years working on Postgres, remember having >>wanted such a thing. I am strongly against mucking with the spinlock >>code for mere aesthetics --- it's too fragile and hard to test, >>especially on platforms you don't have ready access to. >> >>In short, it ain't broken and we don't need to fix it. >> >> > >Agreed. Should the new Solaris ASM code be modified? > > >