X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id A6DBA9FA372 for ; Fri, 5 May 2006 12:51:19 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 58669-08 for ; Fri, 5 May 2006 12:51:09 -0300 (ADT) X-Greylist: delayed 20:34:22.972514 by SQLgrey- Received: from nwkes-gis-mail-1.sun.com (unknown [192.18.42.249]) by postgresql.org (Postfix) with ESMTP id 5D44D9FA509 for ; Fri, 5 May 2006 12:51:08 -0300 (ADT) Received: from d1-sfbay-01.sun.com (d1-sfbay-01 [192.18.39.111]) by nwkes-gis-mail-1.sun.com (8.12.9/8.12.9) with ESMTP id k45Fp76O011074 for ; Fri, 5 May 2006 08:51:07 -0700 (PDT) Received: from conversion-daemon.d1-sfbay-01.sun.com by d1-sfbay-01.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0IYS00E01UFSES00@d1-sfbay-01.sun.com> (original mail from Robert.Lor@Sun.COM) for pgsql-patches@postgresql.org; Fri, 05 May 2006 08:51:07 -0700 (PDT) Received: from [129.150.12.119] by d1-sfbay-01.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0IYS005ANUP6NH30@d1-sfbay-01.sun.com>; Fri, 05 May 2006 08:51:07 -0700 (PDT) Date: Fri, 05 May 2006 08:50:55 -0700 From: Robert Lor Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64 In-reply-to: <200605051222.k45CMxC22692@candle.pha.pa.us> To: Bruce Momjian Cc: Tom Lane , Theo Schlossnagle , Josh.Berkus@Sun.COM, PostgreSQL-patches Message-id: <445B745F.4000901@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=us-ascii Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en References: <200605051222.k45CMxC22692@candle.pha.pa.us> User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7) Gecko/20060307 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200605/60 X-Sequence-Number: 19606 Bruce, the change was only needed for the SPARC version only. The x86 file worked just fine before and needs to be reverted back. Yes, they are different. Apologies if the message was not clear the first time! Thanks, Robert Bruce Momjian wrote: >Done, for Solaris and x86. > >--------------------------------------------------------------------------- > >Robert Lor wrote: > > >>Hi Bruce, >> >>The new SPARC assembly file src/backend/port/tas/solaris_sparc.s uses / >>instead of ! for comments, and as a result the compile fails with Sun >>Studio 11. Please modify the first 3 lines to look like the following. >> >> >> >>>!======================================================================= >>>! solaris_sparc.s -- compare and swap for solaris_sparc >>>!======================================================================= >>> >>> >> >>