DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=Yahoo.com;
	h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=lxODyh7e//F/n5qW8hRX82kDw633tmgRULS/jx9sCDgtsu9W4QnZZ0SHQa6UNrmSweqga/qX53Hq0Dvx1ZT1O+uTrokbfBzb8kmdv2ywDYikd3m9OGw8KHC2PAc22mh3oPTQbT+imUfMvegLzyM5yAQsEtp9L7ed5ClT3mmjdU4=
	;
Message-ID: <47BC9852.9010100@Yahoo.com>
Date: Wed, 20 Feb 2008 16:14:58 -0500
From: Jan Wieck <JanWieck@Yahoo.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Gregory Stark <stark@enterprisedb.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-patches@postgreSQL.org
Subject: Re: Proposed patch to change TOAST compression strategy
References: <26048.1203271939@sss.pgh.pa.us>
	<87ir0mo8ot.fsf@oxford.xeocode.com>
In-Reply-To: <87ir0mo8ot.fsf@oxford.xeocode.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 2/18/2008 5:33 AM, Gregory Stark wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
> 
>> * Adds an early-failure path to the compressor as suggested by Jan:
>> if it's been unable to find even one compressible substring in the
>> first 1KB (parameterizable), assume we're looking at incompressible
>> input and give up.  (There are various ways this could be done, but
>> this way seems to add the least overhead to the compressor's inner
>> loop.)
> 
> I'm not sure how to test the rest of it, but this bit seems testable. I fear
> this may be too conservative. Even nigh incompressible data will find a few
> backreferences.

One could argue that storing JPEG in a bytea column and not configuring 
the column to skip compression is a pilot error. But I guess this 
happens much more often than accidentally finding some data that has 
zero backref within the first KB and changes pattern thereafter. Do you 
have any example for data that is like that?


Jan

-- 
Anyone who trades liberty for security deserves neither
liberty nor security. -- Benjamin Franklin