Message-ID: <4828EBCB.6010004@dunslane.net>
Date: Mon, 12 May 2008 21:15:55 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Simon Riggs <simon@2ndquadrant.com>
CC: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: odd output in restore mode
References: <4828AF1D.7060405@dunslane.net>	
	<1210630440.29684.249.camel@ebony.site>
	<4828CB9D.7070102@dunslane.net>
	<1210635473.29684.268.camel@ebony.site>
In-Reply-To: <1210635473.29684.268.camel@ebony.site>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Simon Riggs wrote:
> On Mon, 2008-05-12 at 18:58 -0400, Andrew Dunstan wrote:
>
>   
>> No, it had to do with pg_standby waiting for a WAL file that had already 
>> gone, somehow. I will try to reproduce it when I get a spare moment.
>>     
>
> Sounds like the bug I just fixed. 
>   


Yes, so I see. I didn't have that fix, so I'll test again with the patch.
>    
>   
>>> There is an outstanding Windows issue with pg_standby that your help
>>> would be appreciated with, shown on latest commitfest page. It's a
>>> Windows issue and I don't maintain a Windows dev environment.
>>>       
>
>   
>> The patch has been rejected for now, according to the Commitfest page. 
>> Not sure what you want my help on.
>>     
>
> Well, the patch was rejected long ago, not sure why its in this
> commitfest. But its an open issue on the Windows port.
>
>   

Surely the right fix is to use the recently implemented 
pgwin32_safestat() (if we aren't already - I suspect we probably are) 
and remove the kluge in pg_standby.c.

cheers

andrew