Received: from localhost (unknown [200.46.204.183]) by developer.postgresql.org (Postfix) with ESMTP id 71E6D2E006B for ; Tue, 17 Jun 2008 15:31:09 -0300 (ADT) Received: from developer.postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 30913-01-4 for ; Tue, 17 Jun 2008 15:30:59 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from hook.sigaev.ru (hook.sigaev.ru [212.192.243.50]) by developer.postgresql.org (Postfix) with ESMTP id 310602E024C for ; Tue, 17 Jun 2008 15:25:51 -0300 (ADT) Received: by hook.sigaev.ru (Postfix, from userid 1003) id 8C372398E2; Tue, 17 Jun 2008 22:25:49 +0400 (MSD) Received: from xor.sai.msu.ru (xor.sai.msu.ru [212.192.243.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hook.sigaev.ru (Postfix) with ESMTP id 7A088398E0 for ; Tue, 17 Jun 2008 22:25:46 +0400 (MSD) Message-ID: <485801AA.1000105@sigaev.ru> Date: Tue, 17 Jun 2008 22:25:46 +0400 From: Teodor Sigaev User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.13) Gecko/20080401 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Patches Subject: Re: GIN improvements References: <483FD205.4090904@sigaev.ru> In-Reply-To: <483FD205.4090904@sigaev.ru> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200806/112 X-Sequence-Number: 6598 > 1) multicolumn GIN > Unlike other indexes, the performance of search > doesn't depends on what column of index (first, last, any subset) is > used in search clause. This property can be used in gincostestimate, but > I haven't looked on it yet. After some playing I didn't find any mentions in *costestimate function about difference of cost estimation between first and any other columns in clauses, so, IMHO, issue above isn't an issue. :) So, I didn't see any comments/objections and I intend to commit this patch for next two days and synchronize 'fast insert into GIN' patch with CVS. Objections? -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/