thread-index: AcjbZ4wuUvvzFnUkTQm5uMjUEbcdCQ==
Content-Class: urn:content-classes:message
Importance: normal
Message-ID: <486A0A86.1080509@enterprisedb.com>
Date: Tue, 01 Jul 2008 13:44:22 +0300
From: "Heikki Linnakangas" <heikki@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509)
MIME-Version: 1.0
To: "Simon Riggs" <simon@2ndquadrant.com>
Cc: "Andrew Dunstan" <andrew@dunslane.net>,
 "Bruce Momjian" <bruce@momjian.us>,
	"Dave Page" <dpage@pgadmin.org>,
	"List pgsql-patches" <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] odd output in restore mode
References: <200806302213.m5UMDCW22128@momjian.us>
	<48696C3F.4060901@dunslane.net>
	<1214901548.3845.544.camel@ebony.site>
In-Reply-To: <1214901548.3845.544.camel@ebony.site>
Content-Type: text/plain;
	format=flowed;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit

Simon Riggs wrote:
> Patch implements
> 
> * recommendation to use GnuWin32 cp on Windows
> * provide "holdtime" delay, default 0 (on all platforms)
> * default stays same on Windows="copy" to ensure people upgrading don't
> get stung

This seems pretty kludgey to me. I wouldn't want to install GnuWin32 
utilities on a production system just for the "cp" command, and I don't 
know how I would tune holdtime properly for using "copy". And it seems 
risky to have defaults that are known to not work reliably.

How about implementing a replacement function for "cp" ourselves? It 
seems pretty trivial to do. We could use that on Unixes as well, which 
would keep the differences between Win32 and other platforms smaller, 
and thus ensure the codepath gets more testing.

(Sorry for jumping into the discussion so late, I didn't follow this 
thread earlier, and just read it now in the archives while looking at 
the patch.)

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com