thread-index: Acjdvd4oEvGOq/JwQC2JKe55DTUq7A==
Content-Class: urn:content-classes:message
Importance: normal
Message-ID: <486DF644.4070604@enterprisedb.com>
Date: Fri, 04 Jul 2008 13:07:00 +0300
From: "Heikki Linnakangas" <heikki@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509)
MIME-Version: 1.0
To: "Pavan Deolasee" <pavan.deolasee@gmail.com>
Cc: "Zdenek Kotala" <Zdenek.Kotala@sun.com>,
	"PostgreSQL-patches" <pgsql-patches@postgresql.org>
Subject: Re: page macros cleanup
References: <48529B83.9010907@sun.com>
	<2e78013d0807030450m4cab60d0jd99d1acce59fae56@mail.gmail.com>
	<486DD1D1.50604@sun.com>
	<2e78013d0807040150w393ad72codaf06a6ac12a83ce@mail.gmail.com>
In-Reply-To: <2e78013d0807040150w393ad72codaf06a6ac12a83ce@mail.gmail.com>
Content-Type: text/plain;
	format=flowed;
	charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit

Pavan Deolasee wrote:
> On Fri, Jul 4, 2008 at 1:01 PM, Zdenek Kotala <Zdenek.Kotala@sun.com> wrote:
>>
>> Good catch. I lost in basic arithmetic. What I see now that original
>> definition count sizeof(ItemIdData) twice and on other side it does not take
>> care about MAXALING correctly. I think correct formula is:
>>
>> #define HashMaxItemSize(page) \
>>        (PageGetPageSize(page) - \
>>          ( MAXALIGN(SizeOfPageHeaderData + sizeof(ItemIdData))+ \
>>            MAXALIGN(sizeof(HashPageOpaqueData)) \
>>          )\
>>         )
>>
>> What do you think?
> 
> Yes. I think that's the correct way.

Doesn't look right to me. There's no padding after the first line 
pointer, hence the first MAXALIGN shouldn't be there.

BTW, looking at hashinsert.c where it's used, we're actually passing a 
pointer to the meta page to HashMaxItemSize(). So the PageGetPageSize() 
call on that is quite bogus, since it's not the meta page that the tuple 
is going to be inserted to. It's academical, because all pages are the 
same size anyway, but doesn't look right. I think I'd go with BLKCSZ 
instead.

I think this is the way it should be:

#define HashMaxItemSize \
	(BLCKSZ - \
	 SizeOfPageHeaderData - \
	 MAXALIGN(sizeof(HashPageOpaqueData)) - \
	 sizeof(ItemIdData))

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com