Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 6B6596501B3; Mon, 7 Jul 2008 10:58:35 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 07541-02; Mon, 7 Jul 2008 10:58:23 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from hook.sigaev.ru (hook.sigaev.ru [212.192.243.50]) by postgresql.org (Postfix) with ESMTP id 9866965017E; Mon, 7 Jul 2008 10:58:28 -0300 (ADT) Received: by hook.sigaev.ru (Postfix, from userid 1003) id 21A3539903; Mon, 7 Jul 2008 17:58:25 +0400 (MSD) Received: from xor.sai.msu.ru (toulouse.jfg-networks.net [82.224.249.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hook.sigaev.ru (Postfix) with ESMTP id 2C033398E1; Mon, 7 Jul 2008 17:58:18 +0400 (MSD) Message-ID: <487220F9.4010403@sigaev.ru> Date: Mon, 07 Jul 2008 17:58:17 +0400 From: Teodor Sigaev User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.13) Gecko/20080401 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Alvaro Herrera CC: Patches , Pgsql Hackers Subject: Re: [PATCHES] GIN improvements References: <483FD205.4090904@sigaev.ru> <486BC501.6060605@sigaev.ru> <20080707134533.GB21091@alvh.no-ip.org> In-Reply-To: <20080707134533.GB21091@alvh.no-ip.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200807/278 X-Sequence-Number: 120538 > I looked this over and it looks good in general. I was only wondering > about for single-column indexes -- we're storing attribute numbers too, > right? No, GinState->oneCol field signals to GinFormTuple and gin_index_getattr/gintuple_get_attrnum about actual storage. Single column index is binary compatible with current index :) -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/