Date: Tue, 08 Jul 2008 21:28:27 +0200
From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Subject: Re: page macros cleanup (ver 04)
In-reply-to: <486E138F.4060900@sun.com>
To: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
	Heikki Linnakangas <heikki@enterprisedb.com>,
	PostgreSQL-patches <pgsql-patches@postgresql.org>
Message-id: <4873BFDB.7020702@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-2
Content-transfer-encoding: 7BIT
References: <48529B83.9010907@sun.com>
	<2e78013d0807030450m4cab60d0jd99d1acce59fae56@mail.gmail.com>
	<486DD1D1.50604@sun.com>
	<2e78013d0807040150w393ad72codaf06a6ac12a83ce@mail.gmail.com>
	<486DF644.4070604@enterprisedb.com>
	<2e78013d0807040350m3b2913cfkceaa70d8f9d697c2@mail.gmail.com>
	<486E01B0.9050100@enterprisedb.com>
	<2e78013d0807040404q5ff7f7faq9f87a39e0f0552fa@mail.gmail.com>
	<486E138F.4060900@sun.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080325)

Pavan, Heikki,

Is it OK now or do you have any comments?

	Thanks Zdenek

Zdenek Kotala napsal(a):
> Pavan Deolasee napsal(a):
>> On Fri, Jul 4, 2008 at 4:25 PM, Heikki Linnakangas
>> <heikki@enterprisedb.com> wrote:
>>>
>>> No, there's a itemsz = MAXALIGN(itemsz) call before the check against
>>> HashMaxItemSize.
>>>
>>
>> Ah, right. Still should we just not MAXALIGN_DOWN the Max size to
>> reflect the practical limit on the itemsz ? It's more academical
>> though, so not a big deal.
> 
> Finally I use following formula:
> 
> #define HashMaxItemSize(page) \
>      MAXALIGN_DOWN(PageGetPageSize(page) - \
>        ( SizeOfPageHeaderData + sizeof(ItemIdData) ) - \
>         MAXALIGN(sizeof(HashPageOpaqueData)) )
> 
> 
> I did not replace PageGetPageSize(page), because other *MaxItemSize has 
> same interface.
> 
> Revised patch is attached.
> 
>         Zdenek
> 
> 
> ------------------------------------------------------------------------
> 
>