Received: from localhost (unknown [200.46.204.183])
	by postgresql.org (Postfix) with ESMTP id 2D3B064FCF3
	for <pgsql-hackers-postgresql.org@postgresql.org>;
	Fri, 25 Jul 2008 04:48:35 -0300 (ADT)
Received: from postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 14260-01 for
	<pgsql-hackers-postgresql.org@postgresql.org>;
	Fri, 25 Jul 2008 04:48:23 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from hook.sigaev.ru (hook.sigaev.ru [212.192.243.50])
	by postgresql.org (Postfix) with ESMTP id 83AF564FCD6
	for <pgsql-hackers@postgresql.org>;
	Fri, 25 Jul 2008 04:48:25 -0300 (ADT)
Received: by hook.sigaev.ru (Postfix, from userid 1003)
	id 3756C398EF; Fri, 25 Jul 2008 11:48:28 +0400 (MSD)
Received: from xor.sai.msu.ru (mx.pragmatic.ru [80.244.231.102])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hook.sigaev.ru (Postfix) with ESMTP id 90308398E0;
	Fri, 25 Jul 2008 11:48:25 +0400 (MSD)
Message-ID: <48898548.8050603@sigaev.ru>
Date: Fri, 25 Jul 2008 11:48:24 +0400
From: Teodor Sigaev <teodor@sigaev.ru>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.15) Gecko/20080715 SeaMonkey/1.1.10
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] GIN improvements
References: <483FD205.4090904@sigaev.ru> <486BC501.6060605@sigaev.ru>
	<27880.1215810535@sss.pgh.pa.us> <487A6E0C.3090600@sigaev.ru>
	<8993.1216843701@sss.pgh.pa.us> <4888A594.6010102@sigaev.ru>
	<7913.1216918895@sss.pgh.pa.us> <4888D6DB.8030100@sigaev.ru>
	<10899.1216931409@sss.pgh.pa.us>
In-Reply-To: <10899.1216931409@sss.pgh.pa.us>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200807/1168
X-Sequence-Number: 121428



> (a) that's not back-patchable and (b) it'll create a merge conflict with
> your patch, if you're still going to add a new AM function column.
> I think that aminsertcleanup per se isn't needed, but if we want an
> "amanalyze" there'd still be a conflict.  Where are we on that?

I'll revert aminsertcleanup framework but leave gininsertcleanup function as is, 
because I'll not have enough time until end of summer - I'd like to finalize 
patch and fixes first.

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/