Message-ID: <488DEE79.4010004@dunslane.net>
Date: Mon, 28 Jul 2008 12:06:17 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Greg Smith <gsmith@gregsmith.com>
CC: Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	Simon Riggs <simon@2ndquadrant.com>,
	Heikki Linnakangas <heikki@enterprisedb.com>,
	Bruce Momjian <bruce@momjian.us>, Dave Page <dpage@pgadmin.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	List pgsql-patches <pgsql-patches@postgresql.org>,
	Martin Zaun <Martin.Zaun@Sun.COM>
Subject: Re: [PATCHES] odd output in restore mode
References: <200807011520.m61FKhZ20311@momjian.us> <48867904.9090001@sun.com>
	<1216810783.3894.602.camel@ebony.2ndQuadrant>
	<48877AC0.7070603@enterprisedb.com>
	<48873C7E.EE98.0025.0@wicourts.gov>
	<Pine.GSO.4.64.0807281136140.26479@westnet.com>
In-Reply-To: <Pine.GSO.4.64.0807281136140.26479@westnet.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit


Greg Smith wrote:
> On Wed, 23 Jul 2008, Kevin Grittner wrote:
>
>> In our scripts we handle this by copying to a temp directory on the
>> same mount point as the archive directory and doing a mv to the
>> archive location when the copy is successfully completed. I think
>> that this even works on Windows. Could that just be documented as a
>> strong recommendation for the archive script?
>
> This is exactly what I always do. I think the way cp is shown in the 
> examples promotes what's really a bad practice for lots of reasons, 
> this particular problem being just one of them.
>
> I've been working on an improved archive_command shell script that I 
> expect to submit for comments and potential inclusion in the 
> documentation as a better base for other people to build on. This is 
> one of the options for how it can operate. It would be painful but not 
> impossible to convert a subset of that script to run under Windows as 
> well, at least enough to cover this particular issue.
>
>

A Perl script using the (standard) File::Copy module along with the 
builtin function rename() should be moderately portable. It would to be 
nice not to have to maintain two scripts.

cheers

andrew