Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 1CC24650201; Thu, 31 Jul 2008 13:05:31 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 15073-01; Thu, 31 Jul 2008 13:05:26 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail01.enterprisedb.com (mail01.enterprisedb.com [63.246.7.168]) by postgresql.org (Postfix) with ESMTP id 702C8650208; Thu, 31 Jul 2008 13:05:25 -0300 (ADT) thread-index: AcjzJ1swVKlfpt9dSYCe512hdBC2hg== Content-Class: urn:content-classes:message Importance: normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.4133 Received: from [80.222.78.63] ([80.222.78.63]) by mail01.enterprisedb.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 31 Jul 2008 12:06:13 -0400 Message-ID: <4891E2BC.203@enterprisedb.com> Date: Thu, 31 Jul 2008 19:05:16 +0300 From: "Heikki Linnakangas" Organization: EnterpriseDB User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509) MIME-Version: 1.0 To: "Martin Zaun" Cc: "Andrew Dunstan" , "Greg Smith" , "Kevin Grittner" , "Simon Riggs" , "Bruce Momjian" , "Dave Page" , "PostgreSQL-development" , "List pgsql-patches" Subject: Re: [PATCHES] odd output in restore mode References: <200807011520.m61FKhZ20311@momjian.us> <48867904.9090001@sun.com> <1216810783.3894.602.camel@ebony.2ndQuadrant> <48877AC0.7070603@enterprisedb.com> <48873C7E.EE98.0025.0@wicourts.gov> <488DEE79.4010004@dunslane.net> <488F28CB.8000201@enterprisedb.com> <48909C16.6070401@sun.com> In-Reply-To: <48909C16.6070401@sun.com> Content-Type: text/plain; format=flowed; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 31 Jul 2008 16:06:13.0156 (UTC) FILETIME=[5ABB5640:01C8F327] X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200807/1470 X-Sequence-Number: 121730 Martin Zaun wrote: > Heikki Linnakangas wrote: >> Andrew Dunstan wrote: >>> Greg Smith wrote: >>>> On Wed, 23 Jul 2008, Kevin Grittner wrote: >>>> >>>> I've been working on an improved archive_command shell script that I >>>> expect to submit for comments and potential inclusion in the >>>> documentation as a better base for other people to build on. This is >>>> one of the options for how it can operate. It would be painful but >>>> not impossible to convert a subset of that script to run under >>>> Windows as well, at least enough to cover this particular issue. >>> >>> A Perl script using the (standard) File::Copy module along with the >>> builtin function rename() should be moderately portable. It would to >>> be nice not to have to maintain two scripts. >> >> It's also not very nice to require a Perl installation on Windows, >> just for a replacement of Copy. Would a simple .bat script work? > > With these avenues to be explored, can the pg_standby patch on the > CommitFest wiki be moved to the "Returned with Feedback" section? Yes, I think we can conclude that we don't want this patch as it is. Instead, we want a documentation patch that describes the problem, mentioning that GNU cp is safe, or you can use the copy+rename trick. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com