Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id F20C46501F1 for ; Mon, 1 Sep 2008 15:55:41 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 46952-06 for ; Mon, 1 Sep 2008 15:55:36 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.24]) by postgresql.org (Postfix) with ESMTP id E1C8D6501AF for ; Mon, 1 Sep 2008 15:55:37 -0300 (ADT) Received: by ey-out-2122.google.com with SMTP id 6so748051eyi.61 for ; Mon, 01 Sep 2008 11:55:35 -0700 (PDT) Received: by 10.210.47.7 with SMTP id u7mr6921334ebu.165.1220295335499; Mon, 01 Sep 2008 11:55:35 -0700 (PDT) Received: from ?80.222.42.69? ( [80.222.42.69]) by mx.google.com with ESMTPS id c4sm34539978nfi.13.2008.09.01.11.55.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 01 Sep 2008 11:55:34 -0700 (PDT) Message-ID: <48BC3AA4.7060804@enterprisedb.com> Date: Mon, 01 Sep 2008 21:55:32 +0300 Organization: EnterpriseDB User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509) MIME-Version: 1.0 To: Karl Schnaitter CC: pgsql-patches@postgresql.org Subject: Re: fixing bug in combocid.c References: <48B87164.4050802@soe.ucsc.edu> In-Reply-To: <48B87164.4050802@soe.ucsc.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit From: Heikki Linnakangas X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/2 X-Sequence-Number: 7017 Karl Schnaitter wrote: > This patch is for a bug in backend/utils/time/combocid.c. > > In HeapTupleHeaderAdjustCmax, the code makes the incorrect assumption > that the raw command id corresponds to cmin, when the raw command id can > in fact be a combo cid. It needs to be fixed to call > HeapTupleHeaderGetCmin to get cmin. That's all there is to my patch, but > read on for more details. Yep. Patch committed. Thanks for the report! > This is my first patch; I hope I did it right! You did well :-). No need to tar or gzip small patches like that, though. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com