Message-ID: <48C16BA4.2060407@enterprisedb.com>
Date: Fri, 05 Sep 2008 20:25:56 +0300
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509)
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: David Rowley <dgrowley@gmail.com>, 'Peter Eisentraut' <peter_e@gmx.net>,
	pgsql-patches@postgresql.org
Subject: Re: [HACKERS] TODO item: Implement Boyer-Moore searching
	(First time hacker)
References: <2F2A1443F6064162BECA6BB37625222E@amd64>
	<27136.1220634737@sss.pgh.pa.us>
In-Reply-To: <27136.1220634737@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

Tom Lane wrote:
> "David Rowley" <dgrowley@gmail.com> writes:
>> Tom Lane wrote:
>>> Hmm.  B-M-H has worst case search speed O(M*N) (where M = length of
>>> pattern, N = length of search string); whereas full B-M is O(N). Maybe we
>>> should build the second table when M is large? 
> 
>> I'll look into this. If it pays off for longer searches I'll submit a patch.
>> I won't have the time until after the 15th, so perhaps that's in November's
>> commit fest?
> 
> Yes.  Let's get B-M-H in during this fest and then you can look into
> whether a follow-on patch is worthwhile.

Agreed.

Also, it would be nice to use B-M(-H) for LIKE as well. That's a 
different codepath, but probably more widely used than textpos and 
frients. I haven't looked how feasible it would be to do, though.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com