Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 2FC9964FCE6 for ; Mon, 8 Sep 2008 04:49:51 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 65208-03 for ; Mon, 8 Sep 2008 04:49:43 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by postgresql.org (Postfix) with ESMTP id ACF03650030 for ; Mon, 8 Sep 2008 04:49:41 -0300 (ADT) Received: by nf-out-0910.google.com with SMTP id c7so355310nfi.23 for ; Mon, 08 Sep 2008 00:49:39 -0700 (PDT) Received: by 10.210.80.2 with SMTP id d2mr7973613ebb.147.1220860179409; Mon, 08 Sep 2008 00:49:39 -0700 (PDT) Received: from ?80.222.42.69? ( [80.222.42.69]) by mx.google.com with ESMTPS id d24sm20042388nfh.16.2008.09.08.00.49.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 08 Sep 2008 00:49:38 -0700 (PDT) Message-ID: <48C4D910.90401@enterprisedb.com> Date: Mon, 08 Sep 2008 10:49:36 +0300 Organization: EnterpriseDB User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509) MIME-Version: 1.0 To: David Rowley CC: 'Tom Lane' , 'Peter Eisentraut' , pgsql-hackers@postgresql.org Subject: Re: [PATCHES] TODO item: Implement Boyer-Moore searching (First time hacker) References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit From: Heikki Linnakangas X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/490 X-Sequence-Number: 123619 David Rowley wrote: > Thanks for all the reviews and suggestions. David, could you re-run the performance tests you ran earlier? I'm curious to know what impact switching to the simpler loop for 1-byte pattern had. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com