Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 2766364FCCF for ; Fri, 19 Sep 2008 16:50:57 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 31323-03 for ; Fri, 19 Sep 2008 16:50:53 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.esilo.com (mail.esilo.com [63.150.152.211]) by postgresql.org (Postfix) with ESMTP id 4F86464FCC7 for ; Fri, 19 Sep 2008 16:50:53 -0300 (ADT) Received: from [10.0.0.2] (fwext-esilo-jupiter.esilo.com [64.135.45.146]) (authenticated bits=0) by mail.esilo.com (8.13.1/8.13.1) with ESMTP id m8JJohUV019324; Fri, 19 Sep 2008 15:50:48 -0400 Message-ID: <48D4028E.4060306@esilo.com> Date: Fri, 19 Sep 2008 15:50:38 -0400 From: Andrew Chernow User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Tom Lane CC: Alvaro Herrera , PostgreSQL-development , Merlin Moncure Subject: Re: [PATCHES] libpq events patch (with sgml docs) References: <48C18533.2000204@esilo.com> <20080905192215.GK4353@alvh.no-ip.org> <48C18B48.509@esilo.com> <20080905194853.GL4353@alvh.no-ip.org> <48C191A7.3000205@esilo.com> <20080905201504.GM4353@alvh.no-ip.org> <48C19759.90402@esilo.com> <27615.1221619326@sss.pgh.pa.us> <48D072E3.6010703@esilo.com> <28673.1221622817@sss.pgh.pa.us> <48D080B0.6070104@esilo.com> <454.1221626213@sss.pgh.pa.us> <48D0DFBE.9050900@esilo.com> <8872.1221653812@sss.pgh.pa.us> <48D1041D.5070808@esilo.com> <10839.1221658586@sss.pgh.pa.us> <48D11443.4010608@esilo.com> <48D11631.8070709@esilo.com> <28666.1221840662@sss.pgh.pa.us> <48D3EBEC.1040503@esilo.com> <23044.1221853438@sss.pgh.pa.us> In-Reply-To: <23044.1221853438@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/1261 X-Sequence-Number: 124390 Tom Lane wrote: > BTW, why are all the conn parameters to events declared "const"? Isn't Because it looked prettier? Kidding. No idea, do you want me to change that or do you want to? > the reason for passing them in mainly to give the event proc a chance > to issue queries? > > Partly. You also want to give the eventproc a chance to issue a PQinstanceData call, so it can copy stuff to the created result. -- Andrew Chernow eSilo, LLC every bit counts http://www.esilo.com/