Message-ID: <48E5544B.5050103@dunslane.net>
Date: Thu, 02 Oct 2008 19:07:55 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Simon Riggs <simon@2ndQuadrant.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] Infrastructure changes for recovery
References: <1218109459.4549.423.camel@ebony.2ndQuadrant>	
	<1220213074.4371.173.camel@ebony.2ndQuadrant>	
	<1905.1220895241@sss.pgh.pa.us>	
	<1221080797.3913.768.camel@ebony.2ndQuadrant>	
	<15776.1221594318@sss.pgh.pa.us>	
	<1221725145.3913.2315.camel@ebony.2ndQuadrant>	
	<16992.1221743196@sss.pgh.pa.us>	
	<1221745847.3913.2408.camel@ebony.2ndQuadrant>	
	<18549.1221746983@sss.pgh.pa.us>	
	<1222121161.4445.248.camel@ebony.2ndQuadrant>	
	<1222184541.4445.400.camel@ebony.2ndQuadrant>	
	<28973.1222381719@sss.pgh.pa.us>
	<1222985488.4445.1625.camel@ebony.2ndQuadrant>
In-Reply-To: <1222985488.4445.1625.camel@ebony.2ndQuadrant>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Simon Riggs wrote:
> On Thu, 2008-09-25 at 18:28 -0400, Tom Lane wrote:
>   
>> Simon Riggs <simon@2ndQuadrant.com> writes:
>>     
>>> Version 7
>>>       
>> After reading this for awhile, I realized that there is a rather
>> fundamental problem with it: it switches into "consistent recovery"
>> mode as soon as it's read WAL beyond ControlFile->minRecoveryPoint.
>>     
>
> Just seen this patch has been bounced into November CommitFest, even
> though the new patch fixes all of the concerns raised.
>
> I'm concerned that this is going to make the final Hot Standby patch
> fairly large, which will make it even harder to review, test and
> generally get accepted.
>
> What's the best way to make this easier for you/others to review?
>
>   

The fact that it's been put on the November list doesn't mean it can't 
be reviewed and committed before then.

cheers

andrew