Message-ID: <48EB7E11.4010603@enterprisedb.com>
Date: Tue, 07 Oct 2008 18:19:45 +0300
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.16 (X11/20080724)
MIME-Version: 1.0
To: Simon Riggs <simon@2ndQuadrant.com>
CC: Alvaro Herrera <alvherre@commandprompt.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] Infrastructure changes for recovery
References: <1221745847.3913.2408.camel@ebony.2ndQuadrant>
	<18549.1221746983@sss.pgh.pa.us>
	<1222121161.4445.248.camel@ebony.2ndQuadrant>
	<1222184541.4445.400.camel@ebony.2ndQuadrant>
	<28973.1222381719@sss.pgh.pa.us>
	<1222985488.4445.1625.camel@ebony.2ndQuadrant>
	<48E5544B.5050103@dunslane.net>
	<1223367445.4747.105.camel@ebony.2ndQuadrant>
	<13866.1223388527@sss.pgh.pa.us>
	<1223389637.4747.194.camel@ebony.2ndQuadrant>
	<20081007143707.GA19440@alvh.no-ip.org>
In-Reply-To: <20081007143707.GA19440@alvh.no-ip.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

Alvaro Herrera wrote:
> Simon Riggs wrote:
>> I'm just grumpy because I can't see a way to do the
>> patch-on-patch-on-patch that I'll need to make this all work for Nov 1.
>> So big patch here we come. But that's just the way it is and I'll stop
>> honking about it.
> 
> This is one of the problems that DVCSs are supposed to solve ... have
> you tried Git?

Yeah, I maintained a relforks patch + FSM patch on top of that for quite 
some time using git. It's still a bit of work, for sure, but it's possible.

The bottom line is that hot standby is a big feature, and probably a big 
patch. No amount of version control will work around that. Finishing all 
that in a few weeks is a very ambitious goal. I wish you luck, and I 
wish I could do more to help you with that; it's a feature I'd really 
like to see in 8.4. Given how many iterations just this part of the 
patch needed, and it's still not there, the little project manager in me 
says that we really need to be seeing the complete patch or patches very 
soon, and do a first round of review well before the commit fest. The 
risk that we have to drop it as unfinished in November is very high 
otherwise.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com