DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=frogthinker.org;
	h=Received:Message-ID:Date:From:Organization:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=w57fd4iakmFGO7CFsCAq94MK58dh8r8UhqH9uCPrR0kIUiOihekZWYp7YOzqvn2Sv0IQ4a+Kz4uqFUOYVY28XLJSO+AMOzepeZfbfOl0vLHSjWpjx8/rcvbPX0aAkmFV;
Message-ID: <48FFA001.7030201@frogthinker.org>
Date: Wed, 22 Oct 2008 17:49:53 -0400
From: Emmanuel Cecchet <manu@frogthinker.org>
Organization: Frog Thinker
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Jaime Casanova <jcasanov@systemguards.com.ec>
CC: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version
 1
References: <d3c4af540803210745j5ded6107r5871095a3aeb91af@mail.gmail.com>	
	<200803211518.m2LFIfJ12397@momjian.us>	
	<3073cc9b0810181308y91deed8wac2df9bc925200f5@mail.gmail.com>	
	<a301bfd90810220221j389258d5n6940bb8d2f550709@mail.gmail.com>	
	<3073cc9b0810220743p11526a74ve9769a416c1707cf@mail.gmail.com>
	<3073cc9b0810220744y987173avd560a33fcb58ede5@mail.gmail.com>
In-Reply-To: <3073cc9b0810220744y987173avd560a33fcb58ede5@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Another advantage of triggers over rules is that it would work with COPY 
which is probably a desired feature.

Emmanuel

Jaime Casanova wrote:
> just remembering that -patches is a dead list, so i'm sending this to
> -hackers where it will have more visibility...
>
> ---------- Forwarded message ----------
> From: Jaime Casanova <jcasanov@systemguards.com.ec>
> Date: Oct 22, 2008 9:43 AM
> Subject: Re: [PATCHES] Auto Partitioning Patch - WIP version 1
> To: Nikhil Sontakke <nikhil.sontakke@enterprisedb.com>
> Cc: Bruce Momjian <bruce@momjian.us>, NikhilS <nikkhils@gmail.com>,
> Simon Riggs <simon@2ndquadrant.com>, pgsql-patches@postgresql.org
>
>
> On 10/22/08, Nikhil Sontakke <nikhil.sontakke@enterprisedb.com> wrote:
>   
>> Hi,
>>
>>     
>>>>> Thanks for taking a look. But if I am not mistaken Gavin and co. are
>>>>>           
>> working
>>     
>>>>> on a much exhaustive proposal. In light of that maybe this patch might
>>>>>           
>> not
>>     
>>>>> be needed in the first place?
>>>>>
>>>>> I will wait for discussion and a subsequent collective consensus here,
>>>>> before deciding the further course of actions.
>>>>>           
>>>> I think it is unwise to wait on Gavin for a more complex implemention
>>>> ---  we might end up with nothing for 8.4.  As long as your syntax is
>>>> compatible with whatever Gavin proposed Gavin can add on to your patch
>>>> once it is applied.
>>>>
>>>>         
>>> seems like you're a prophet... or i miss something?
>>>
>>>       
>> :)
>>
>> Maybe I will try to summarize the functionality of this patch, rebase it
>> against latest CVS head and try to get it on the commitfest queue atleast
>> for further feedback to keep the ball rolling on auto-partitioning...
>>
>>     
>
> yeah! i was thinking on doing that but still have no time... and
> frankly you're the best man for the job ;)
>
> one thing i was thinking of is to use triggers instead of rules just
> as our current docs recommends
> http://www.postgresql.org/docs/8.3/static/ddl-partitioning.html
>
> with the benefit that a trigger can check if the child table exists
> for the range being inserted and if not it can create it first...
> haven't looked at the code in the detail but seems that your patch is
> still missing the "create rule" part so we are in time to change
> that... no?
>   

-- 
Emmanuel Cecchet
FTO @ Frog Thinker 
Open Source Development & Consulting
--
Web: http://www.frogthinker.org
email: manu@frogthinker.org
Skype: emmanuel_cecchet