Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id DCBCA650148;
	Mon, 15 Dec 2008 18:08:19 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 63784-02; Mon, 15 Dec 2008 18:08:17 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from svr2.hagander.net (svr2.hagander.net [88.198.128.226])
	by mail.postgresql.org (Postfix) with ESMTP id 18232650109;
	Mon, 15 Dec 2008 18:08:17 -0400 (AST)
Received: from dynamic.hagander.net ([127.0.0.1]) (encrypted and
	authenticated) by svr2.hagander.net (Postfix) with ESMTP id
	22CB2DCC383; Mon, 15 Dec 2008 23:08:15 +0100 (CET)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by mha-laptop.hagander.net (Postfix) with ESMTP id 9DE681240C6;
	Mon, 15 Dec 2008 23:08:14 +0100 (CET)
Message-ID: <4946D54E.4060406@hagander.net>
Date: Mon, 15 Dec 2008 23:08:14 +0100
From: Magnus Hagander <magnus@hagander.net>
User-Agent: Thunderbird 2.0.0.18 (X11/20081125)
MIME-Version: 1.0
To: Bruce Momjian <bruce@momjian.us>
CC: Martin Zaun <Martin.Zaun@Sun.COM>, Simon Riggs <simon@2ndquadrant.com>,
	Heikki Linnakangas <heikki@enterprisedb.com>,
	Andrew Dunstan <andrew@dunslane.net>, Dave Page <dpage@pgadmin.org>,
	List pgsql-patches <pgsql-patches@postgresql.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] odd output in restore mode
References: <200812152115.mBFLFpV20891@momjian.us>
In-Reply-To: <200812152115.mBFLFpV20891@momjian.us>
X-Enigmail-Version: 0.95.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200812/1207
X-Sequence-Number: 129836

Bruce Momjian wrote:
> Martin Zaun wrote:
>> 4. Issue: missing break in switch, silent override of '-l' argument?
>>
>> This behaviour has been in there before and is not addresses by the
>> patch: The user-selected Win32 "mklink" command mode is never applied
>> due to a missing 'break' in CustomizableInitialize():
>>
>>      switch (restoreCommandType)
>>      {
>>          case RESTORE_COMMAND_WIN32_MKLINK:
>>              SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath);
>>          case RESTORE_COMMAND_WIN32_COPY:
>>              SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath);
>>              break;
> 
> I have added the missing 'break' to CVS HEAD;  thanks.

Why no backpatch to 8.3? Seems like a clear bugfix to me.

//Magnus